-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acknowledge that jacquev6's packages support OCaml 4.06.0 #11387
Conversation
✅ All lint checks passed d7b1577
✅ Installability check (8296 → 8296) |
Does your packages depends on OCaml's internals to have those upper-bound constraints ? |
@jpdeplaix I agree they should not, but 4.06.0 introduced a backward incompatibility : the I remember having similar issues when porting my code from 4.02.3 to 4.05.0. That's why I said "< 4.06.0" in the first place, and why I consider safer to put "< 4.07.0" now. I'm open to suggestions though. |
I think it definitely better to just allow every upcoming versions and wait the checks before each releases. If there is a problem with any upcoming versions your opam file will be patched by the maintainers or by any contributors and you will be notified if something needs to be changed on your side. But putting such constraints in advance because it might brake later (like any other packages btw) is probably too restrictive I think. |
If there are automated checks for new OCaml versions, this sounds fine. I just don't want to ever be in a situation where my packages end up broken, I don't know it and people don't know if it's my responsibility or if it comes from some other changes somewhere else. I'll update this PR soon. |
This reflects the following commits: - jacquev6/General@df2a4f9#diff-ce1095cc45339eed28fa39a706eac56a - jacquev6/JsOfOCairo@3912f73#diff-91a565848e6c3dd4496c366fd0be1393 - jacquev6/hashids-ocaml@78c1cc0#diff-537f3ffa3dd84ab6601fdf4a033a7b1f - jacquev6/DrawGrammar@e8dc473#diff-16e2f48684fed3e20eecb51788c587d1 No code had to be modified to support of OCaml 4.06.0, so the existing archives are usable as-is, and modifying the *.opam files is enough. My package sphinxcontrib-ocaml will require more work.
As discussed with @jpdeplaix in ocaml#11387
I've rebased my initial change and removed the upper version constraints. |
For the "ci/datakit/5 V1.2 All Distros" check, the error is:
For the "1 arm64 V2.0 Build" check, the error is:
I have no idea how to help fixing these errors. |
Do not worry about these errors, some bits of the CI is still experimental... The changes look good to me, merging. |
Thanks @samoht! |
This reflects the following commits:
No code had to be modified to support of OCaml 4.06.0, so the
existing archives are usable as-is, and modifying the *.opam files
is enough.
My package sphinxcontrib-ocaml will require more work.