Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledge that jacquev6's packages support OCaml 4.06.0 #11387

Merged
merged 2 commits into from
Feb 15, 2018

Conversation

jacquev6
Copy link
Contributor

This reflects the following commits:

No code had to be modified to support of OCaml 4.06.0, so the
existing archives are usable as-is, and modifying the *.opam files
is enough.

My package sphinxcontrib-ocaml will require more work.

@camelus
Copy link
Contributor

camelus commented Feb 10, 2018

✅ All lint checks passed d7b1577
  • These packages passed lint tests: DrawGrammar.0.2.1, General.0.4.0, JsOfOCairo.1.0.1, hashids.1.0.0

✅ Installability check (8296 → 8296)

@kit-ty-kate
Copy link
Member

Does your packages depends on OCaml's internals to have those upper-bound constraints ?

@jacquev6
Copy link
Contributor Author

@jpdeplaix I agree they should not, but 4.06.0 introduced a backward incompatibility : the num library now needs to be installed via opam. So as they were, my packages would have been broken for 4.06.0.

I remember having similar issues when porting my code from 4.02.3 to 4.05.0. That's why I said "< 4.06.0" in the first place, and why I consider safer to put "< 4.07.0" now. I'm open to suggestions though.

@kit-ty-kate
Copy link
Member

I think it definitely better to just allow every upcoming versions and wait the checks before each releases. If there is a problem with any upcoming versions your opam file will be patched by the maintainers or by any contributors and you will be notified if something needs to be changed on your side.

But putting such constraints in advance because it might brake later (like any other packages btw) is probably too restrictive I think.

@jacquev6
Copy link
Contributor Author

If there are automated checks for new OCaml versions, this sounds fine.

I just don't want to ever be in a situation where my packages end up broken, I don't know it and people don't know if it's my responsibility or if it comes from some other changes somewhere else.

I'll update this PR soon.

@jacquev6
Copy link
Contributor Author

I've rebased my initial change and removed the upper version constraints.

@jacquev6
Copy link
Contributor Author

For the "ci/datakit/5 V1.2 All Distros" check, the error is:

The following command needs to be run through "sudo":
    apt-get install -qq -yy libcairo2-dev libexpat1-dev libgtk2.0-dev
E: Unable to correct problems, you have held broken packages.
OS package installation failed

For the "1 arm64 V2.0 Build" check, the error is:

docker: Error response from daemon: connection error: desc = "transport: dial unix:///var/run/docker/containerd/docker-containerd.sock: timeout".

I have no idea how to help fixing these errors.

@samoht
Copy link
Member

samoht commented Feb 15, 2018

Do not worry about these errors, some bits of the CI is still experimental... The changes look good to me, merging.

@samoht samoht merged commit 5f48b40 into ocaml:master Feb 15, 2018
@jacquev6
Copy link
Contributor Author

Thanks @samoht!

jacquev6 added a commit to jacquev6/JsOfOCairo that referenced this pull request Feb 24, 2018
jacquev6 added a commit to jacquev6/General that referenced this pull request Mar 9, 2018
jacquev6 added a commit to jacquev6/hashids-ocaml that referenced this pull request Apr 24, 2018
jacquev6 added a commit to jacquev6/DrawGrammar that referenced this pull request Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants