Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitv <1.3 does not work with safe-string #11441

Merged
merged 1 commit into from Feb 19, 2018

Conversation

nekketsuuu
Copy link
Contributor

@nekketsuuu nekketsuuu commented Feb 18, 2018

Related issue: backtracking/bitv#10

$ opam switch show
4.06.0
$ opam install bitv.1.2
The following actions will be performed:
  - install bitv 1.2

=-=- Gathering sources =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
[bitv] Archive in cache

=-=- Processing actions -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
[ERROR] The compilation of bitv failed at "make".
Processing  1/1: [bitv: ocamlfind remove]
#=== ERROR while installing bitv.1.2 ==========================================#
# opam-version 1.2.2
# os           linux
# command      make
# path         /home/nek/.opam/4.06.0/build/bitv.1.2
# compiler     4.06.0
# exit-code    2
# env-file     /home/nek/.opam/4.06.0/build/bitv.1.2/bitv-9467-6d07ae.env
# stdout-file  /home/nek/.opam/4.06.0/build/bitv.1.2/bitv-9467-6d07ae.out
# stderr-file  /home/nek/.opam/4.06.0/build/bitv.1.2/bitv-9467-6d07ae.err
### stdout ###
# ocamlc.opt -c  bitv.mli
# ocamlc.opt -c  bitv.ml
# Makefile:112: recipe for target 'bitv.cmo' failed
### stderr ###
# File "bitv.ml", line 528, characters 29-74:
# Warning 3: deprecated: String.set
# Use Bytes.set instead.
# File "bitv.ml", line 528, characters 29-30:
# Error: This expression has type string but an expression was expected of type
#          bytes
# make: *** [bitv.cmo] Error 2



=-=- Error report -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
The following actions failed
  - install bitv 1.2
No changes have been performed
$ opam install bitv.1.3
The following actions will be performed:
  ∗  install bitv 1.3

=-=- Gathering sources =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
[bitv] Archive in cache

=-=- Processing actions -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
∗  installed bitv.1.3
Done.

cc @backtracking

@camelus
Copy link
Contributor

camelus commented Feb 18, 2018

❌ opam-lint errors e6c4bea
  • bitv.1.0 has errors:

    • error 21: Field 'opam-version' doesn't match the current version, validation may not be accurate: "1"
    • error 35: Missing field 'homepage'
    • warning 36: Missing field 'bug-reports'
    • warning 37: Missing field 'dev-repo'
  • bitv.1.1 has errors:

    • error 21: Field 'opam-version' doesn't match the current version, validation may not be accurate: "1"
    • warning 36: Missing field 'bug-reports'
    • warning 37: Missing field 'dev-repo'
  • These packages passed lint tests: bitv.1.2


✅ Installability check (8315 → 8315)

@backtracking
Copy link
Contributor

Indeed I forgot to update the opam packages for bitv when I made release1.3.
Thanks for taking care of that.

@kit-ty-kate
Copy link
Member

Thanks a lot !

@kit-ty-kate kit-ty-kate merged commit cc8170f into ocaml:master Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants