Add Py 1.0

[zshipko]

No description provided.

[camelus]

✅ All lint checks passed 1dfda4e

• These packages passed lint tests: py.1.0

---

✅ Installability check (8323 → 8324)

• new installable packages (1): py.1.0

[zshipko]

It looks like m4 is missing on Alpine, or is this something I need to fix on my end?

[mseri]

I think it's more general, plenty of packages are failing in that way. This looks fine

[mseri]

You can remove this line, it's necessary only if you have depopts (same for the tags)

[mseri]

I can see on the repository that you have tests but you don't have a build-test secion in the opam file to run them in the CI. Probably it's worth adding it

[zshipko]

Okay, @mseri - I have made your suggested changes. Please let me know if there is anything else I should address before it's ready to merge.

Thanks.

[mseri]

Thanks! The tests now are failing. I think it's due to the missing python devel libraries. You should be able to fix it in most cases adding specific depexts to the opam file. I think the following should be enough

depexts: [
  [["debian"] ["python3-dev"]]
  [["ubuntu"] ["python3-dev"]]
  [["fedora"] ["python3-devel"]]
  [["centos"] ["python3-devel"]]
  [["alpine"] ["python3-dev"]]
]

[zshipko]

@mseri, Thanks! I have updated the depexts, but it seems to be failing on CentOS now as well.

[mseri]

Mmh, it’s a bit trickier than that. The error now says

libpython3.4m.so: undefined symbol: Py_DecodeLocale

And from python’s documentation looks like this symbol has been introduced in python 3.5
I don’t think there is an easy way to restrict the depext to python > 3.5, I am not sure if you can/want to do anything about that. You could drop support for python3.4or maybe there is a way to define the call depending on the detected python version

[zshipko]

Hmm, yeah I saw that. I don't think I want to support Python 3.4 right now. Thanks for your help.

[hcarty]

@zshipko It's ok to only support Python 3.5. It may be better to leave out the depext for OS distributions which don't provide a recent enough Python version and include a note stating that Python 3.5 or later is required.

[zshipko]

@hcarty, Great! I've documented the requirement in the descr file. Is that sufficient?

[hcarty]

You could add some extra messages for users (see https://github.com/ocaml/opam-repository/blob/master/packages/lwt/lwt.3.2.1/opam and https://github.com/ocaml/opam-repository/blob/master/packages/mysql/mysql.1.2.2/opam for examples). I think this is ok to merge as-is or with the extra messages. What is your preference @zshipko?

[zshipko]

@hcarty I just added a message to the opam file.

[mseri]

Thanks! I think it’s fine to merge now. I’ll leave it open for comments a bit more and merge in the afternoon

[zshipko]

@mseri Sounds good!

[hcarty]

Agreed that this looks good. Thank you for your patience @zshipko!

[mseri]

Thanks for the patience. Feel free to announce this release on https://discuss.ocaml.org, we have an Announce tag and a Community category (or maybe the other way around) for this purpose