Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package jbuilder.1.0+beta20 #11756

Merged
merged 1 commit into from Apr 12, 2018
Merged

Package jbuilder.1.0+beta20 #11756

merged 1 commit into from Apr 12, 2018

Conversation

rgrinberg
Copy link
Member

jbuilder.1.0+beta20

Fast, portable and opinionated build system

jbuilder is a build system that was designed to simplify the release
of Jane Street packages. It reads metadata from "jbuild" files
following a very simple s-expression syntax.

jbuilder is fast, it has very low-overhead and support parallel builds
on all platforms. It has no system dependencies, all you need to build
jbuilder and packages using jbuilder is OCaml. You don't need or make
or bash as long as the packages themselves don't use bash explicitely.

jbuilder supports multi-package development by simply dropping multiple
repositories into the same directory.

It also supports multi-context builds, such as building against
several opam roots/switches simultaneously. This helps maintaining
packages across several versions of OCaml and gives cross-compilation
for free.

1.0+beta20 (10/04/2018)

@rgrinberg
Copy link
Member Author

@kit-ty-kate here we go again 😆

@camelus
Copy link
Contributor

camelus commented Apr 10, 2018

✅ All lint checks passed a419cef
  • These packages passed lint tests: jbuilder.1.0+beta20
✅ Installability check (8681 → 8682)
  • new installable packages (1): jbuilder.1.0+beta20

@kit-ty-kate
Copy link
Member

kit-ty-kate commented Apr 11, 2018 •
edited

The more complete ARM64 CI is still building revdeps (but expect a lot of failures because core fails on arm64).

However the x86_64 CI finished and here are some (probably unrelated) failures:

@paurkedal
Copy link
Contributor

Yes, the caqti-dynload issue is unrelated (to be fixed by #11730).

@rgrinberg
Copy link
Member Author

How is cmdliner even on that list? It doesn't even use jbuilder.

I checked around half the issues above. All are unrelated. Some are due to incorrect opam files and others just need new releases.

@mjambon would you mind making a new release of biniou

@avsm I made a pr for yaml which should fix things.

@kit-ty-kate
Copy link
Member

@rgrinberg as I said, those failures are unrelated.

@smolkaj
Copy link
Contributor

smolkaj commented Apr 11, 2018

I can confirm that the frenetic problem is unrelated. It is addressed in #11758.

@andersfugmann
Copy link
Contributor

The aws-s3 failures are unrelated. Ill fix the aws-s3 dependencies in a separate PR.

@kit-ty-kate
Copy link
Member

Ok I think the ARM64 CI is never going to finish start (again*) so I'm going to check it manually on a better machine. Hopefully it will be over in the morning.

*: bugs all over the place, sorry.

@kit-ty-kate
Copy link
Member

Ok so the build finished. There are lots of unrelated failures that I'm going to address separately but 3 might be related:

  • amqp-client.1.1.1:
# context              2.0.0~rc | linux/x86_64 | ocaml-base-compiler.4.05.0 | git+file:///home/opam/opam-repository
# path                 ~/.opam/4.05.0/.opam-switch/build/amqp-client.1.1.1
# command              ~/.opam/4.05.0/bin/jbuilder build -p amqp-client -j 71
# exit-code            1
# env-file             ~/.opam/log/amqp-client-1-1a1e04.env
# output-file          ~/.opam/log/amqp-client-1-1a1e04.out
### output ###
# Library "amqp" is defined twice:
# - lwt/jbuild:29
# - async/jbuild:8
  • kafka.0.3:
#=== ERROR while compiling kafka.0.3 ==========================================#
# context              2.0.0~rc | linux/x86_64 | ocaml-base-compiler.4.05.0 | git+file:///home/opam/opam-repository
# path                 ~/.opam/4.05.0/.opam-switch/build/kafka.0.3
# command              ~/.opam/4.05.0/bin/jbuilder build -p kafka . -j 71 @install
# exit-code            1
# env-file             ~/.opam/log/kafka-1-318504.env
# output-file          ~/.opam/log/kafka-1-318504.out
### output ###
# Don't know how to build .
  • opam-core.2.0.0~beta5:
#=== ERROR while compiling opam-core.2.0.0~beta5 ==============================#
# context              2.0.0~rc | linux/x86_64 | ocaml-base-compiler.4.05.0 | git+file:///home/opam/opam-repository
# path                 ~/.opam/4.05.0/.opam-switch/build/opam-core.2.0.0~beta5
# command              /usr/bin/make opam-core.install
# exit-code            2
# env-file             ~/.opam/log/opam-core-1-450930.env
# output-file          ~/.opam/log/opam-core-1-450930.out
### output ###
# jbuilder build  -p opam-core opam-core.install
# File "jbuild-ignore", line 2, characters 0-16:
# Warning: subdirectory expression src_ext/jbuilder ignored
# File "jbuild-ignore", line 3, characters 0-14:
# Warning: subdirectory expression tests/packages ignored
#        ocaml (internal)
# fatal: Not a git repository (or any of the parent directories): .git
# File "src/core/jbuild", line 19, characters 17-47:
# Error: please quote the string containing the list variable ${@}
# Makefile:87: recipe for target 'opam-core.install' failed
# make: *** [opam-core.install] Error 1

I think the first two were already there for beta19 but they are definitely required to be fixed anyway.

@rgrinberg
Copy link
Member Author

The breakage with amqp-client is certainly intended. I believe @andersfugmann already fixed the problem in master though. Do we need a new release here?

The issue with kafka is not new. I think 0.4 fixes the issue.

cc @dra27 regarding the opam issue.

@kit-ty-kate
Copy link
Member

@rgrinberg a new release is not necessary but very welcome, but they mainly need some extra constraints. Would jbuilder < "1.0+beta18" be ok ? Or is it beta19 ?

@rgrinberg
Copy link
Member Author

For amqp-client it should be < beta 20. For the kafka issue, I'd guess < beta 19. Not 100% sure since those build instructions are just broken and only worked by accident before

@andersfugmann
Copy link
Contributor

andersfugmann commented Apr 12, 2018 •
edited

@rgrinberg amqp-client.2.0.0 should work just fine. I will create PR to restrict the jbuilder version for versions that requires it.

@ghost
Copy link

ghost commented Apr 12, 2018

I had a look at the opam-core build failure. There is indeed something that needs to be fixed in Dune (ocaml/dune#701), but it is not specific to beta20, the problem should exist since beta18. opam-core.2.0.0~rc builds fine with beta20, so I think just adding a < beta19 constraint on opam-core.2.0.0~beta5 should be enough for now.

@ghost ghost mentioned this pull request Apr 12, 2018
Merged
@kit-ty-kate
Copy link
Member

Ok thanks everyone. Merging !

@kit-ty-kate kit-ty-kate merged commit c59ce8a into ocaml:master Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zarith should install zarith.h Problem with computing or solving dependencies
6 participants
@rgrinberg @camelus @kit-ty-kate @paurkedal @smolkaj @andersfugmann