Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otr, tls, x509: upper bound for sexplib #11880

Merged
merged 1 commit into from Apr 29, 2018
Merged

otr, tls, x509: upper bound for sexplib #11880

merged 1 commit into from Apr 29, 2018

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Apr 28, 2018

see #11852

@hannesm hannesm mentioned this pull request Apr 28, 2018
Open
@camelus
Copy link
Contributor

camelus commented Apr 28, 2018 •
edited

❗ opam-lint warnings a5ad220

  • tls.0.7.1 has some warnings:

    • warning 41: Some packages are mentionned in package scripts of features, but there is no dependency or depopt toward them: "ipaddr"

  • These packages passed lint tests: otr.0.3.1, otr.0.3.2, otr.0.3.3, otr.0.3.4, tls.0.8.0, tls.0.9.0, tls.0.9.1, x509.0.5.1, x509.0.5.2, x509.0.5.3, x509.0.6.0, x509.0.6.1

✅ Installability check (8766 → 8766)

kit-ty-kate
kit-ty-kate reviewed Apr 28, 2018
View reviewed changes
packages/otr/otr.0.3.1/opam Outdated
@@ -22,7 +22,7 @@ depends: [
"ppx_tools" {build}
"cstruct" {>= "1.9.0"}
"ppx_cstruct" {build}
"sexplib"
"sexplib" {< "v0.11.0"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it more of an issue with ppx_sexp_conv instead of sexplib directly ?

@hannesm
Copy link
Member Author

hannesm commented Apr 29, 2018

@kit-ty-kate yes, thanks. I force-pushed a commit which changed this (from sexplib to ppx_sexp_conv)

@hannesm hannesm mentioned this pull request Apr 29, 2018
Merged
@kit-ty-kate
Copy link
Member

There are some failures in the revdeps but they are unrelated. Thanks a lot !! :)

@kit-ty-kate kit-ty-kate merged commit a4d98d3 into ocaml:master Apr 29, 2018
@hannesm hannesm deleted the no-sexp.0.11 branch April 29, 2018 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit-ty-kate kit-ty-kate kit-ty-kate left review comments

Assignees
No one assigned
Labels
consider for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hannesm @camelus @kit-ty-kate