Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] dune (1.4.0) #12774

Merged
merged 1 commit into from
Oct 11, 2018
Merged

[new release] dune (1.4.0) #12774

merged 1 commit into from
Oct 11, 2018

Conversation

rgrinberg
Copy link
Member

CHANGES:

CHANGES:

- Do not fail if the output of `ocamlc -config` doesn't include
  `standard_runtime` (ocaml/dune#1326, @diml)

- Let `Configurator.V1.C_define.import` handle negative integers
  (ocaml/dune#1334, @Chris00)

- Re-execute actions when a target is modified by the user inside
  `_build` (ocaml/dune#1343, fix ocaml/dune#1342, @diml)

- Pass `--set-switch` to opam (ocaml/dune#1341, fix ocaml/dune#1337, @diml)

- Fix bad interaction between multi-directory libraries the `menhir`
  stanza (ocaml/dune#1373, fix ocaml/dune#1372, @diml)

- Integration with automatic formatters (ocaml/dune#1252, fix ocaml/dune#1201, @emillon)

- Better error message when using `(self_build_stubs_archive ...)` and
  `(c_names ...)` or `(cxx_names ...)` simultaneously.
  (ocaml/dune#1375, fix ocaml/dune#1306, @nojb)

- Improve name detection for packages when the prefix isn't an actual package
  (ocaml/dune#1361, fix ocaml/dune#1360, @rgrinberg)

- Support for new menhir rules (ocaml/dune#863, fix ocaml/dune#305, @fpottier, @rgrinberg)

- Do not remove flags when compiling compatibility modules for wrapped mode
  (ocaml/dune#1382, fix ocaml/dune#1364, @rgrinberg)

- Fix reason support when using `staged_pps` (ocaml/dune#1384, @charlesetc)

- Add support for `enabled_if` in `rule`, `menhir`, `ocamllex`,
  `ocamlyacc` (ocaml/dune#1387, @diml)

- Exit gracefully when a signal is received (ocaml/dune#1366, @diml)

- Load all defined libraries recursively into utop (ocaml/dune#1384, fix ocaml/dune#1344,
  @rgrinberg)

- Allow to use libraries `bytes`, `result` and `uchar` without `findlib`
  installed (ocaml/dune#1391, @nojb)

- Take argument to self_build_stubs_archive into account. (ocaml/dune#1395, @nojb)

- Fix bad interaction between `env` customization and vendored
  projects: when a vendored project didn't have its own `env` stanza,
  the `env` stanza from the enclosing project was in effect (ocaml/dune#1408,
  @diml)

- Fix stop early bug when scanning for watermarks (ocaml/dune#1423, @diml)
@camelus
Copy link
Contributor

camelus commented Oct 10, 2018

☀️ All lint checks passed 9e08c98
  • These packages passed lint tests: dune.1.4.0

☀️ Installability check (9775 → 9776)
  • new installable packages (1): dune.1.4.0

@kit-ty-kate
Copy link
Member

poke @mseri for the eigen/owl related problems: https://ci.ocamllabs.io/log/saved/docker-run-f22b1fa17d182dc0684d8dabe5c30828/11cc8cb6dc8255040ebf775a45da98d9a3bb40ef

Otherwise there seem to be a related problem that wasn't there before:

#=== ERROR while compiling jupyter-archimedes.2.3.2 ===========================#
# context              2.0.0 | linux/x86_64 | ocaml-base-compiler.4.07.0 | git+file:///home/opam/opam-repository
# path                 ~/.opam/4.07/.opam-switch/build/jupyter-archimedes.2.3.2
# command              ~/.opam/4.07/bin/dune build -p jupyter-archimedes -j 127
# exit-code            1
# env-file             ~/.opam/log/jupyter-archimedes-18-58c0d3.env
# output-file          ~/.opam/log/jupyter-archimedes-18-58c0d3.out
### output ###
# File "jupyter-archimedes/src/dune", line 10, characters 14-30:
# 10 |               archimedes.cairo))
#                    ^^^^^^^^^^^^^^^^
# Error: Library "archimedes.cairo" in /home/opam/.opam/4.07/lib/archimedes is hidden (unsatisfied 'exist_if').
# Hint: try: dune external-lib-deps --missing -p jupyter-archimedes @@default

@mseri
Copy link
Member

mseri commented Oct 11, 2018

Thanks @kit-ty-kate the issue with eigen is due to a too old gcc, unfortunately the install does not fail properly and makes the owl package unusable. We need to find a better way to deal with the external c++ libraries there, but unfortunately there seems to be no easy or right solution.

It can be safely ignored though as it is not related to dune

@mseri
Copy link
Member

mseri commented Oct 11, 2018

@kit-ty-kate
Copy link
Member

But the weird thing is that both didn't fail when tested for dune 1.3.0: https://ci.ocamllabs.io/ocaml/opam-repository/pr/12693?history=b093b1d937b5d9299bf3bb9ae9bdc200886016e5

@rgrinberg
Copy link
Member Author

If I had to guess, it's probably a race condition. Is it possible to restart the build?

@pmetzger
Copy link
Member

If I had to guess, it's probably a race condition. Is it possible to restart the build?

Yes, but you can do it on your own just by force pushing the branch even though it hasn't actually changed. That will trigger a new build.

@Chris00
Copy link
Member

Chris00 commented Oct 11, 2018

The archimedes failure seems to be there also with dune 1.3.1

Archimedes does not use Dune to compile so this is odd.

@mseri
Copy link
Member

mseri commented Oct 11, 2018

We have been imprecise. It is jupyter-Archimedes that fails because Archimedes.cairo appears to be an hidden library

@Chris00
Copy link
Member

Chris00 commented Oct 11, 2018 via email

@kit-ty-kate
Copy link
Member

Yes, but you can do it on your own just by force pushing the branch even though it hasn't actually changed. That will trigger a new build.

as it's just from datakit ci, everyone can just relaunch the build by clicking "rebuild". It would avoid unnecessary rebuilds

@mseri
Copy link
Member

mseri commented Oct 11, 2018

Anyways it doesn’t really matter now as @Chris00 clarified how jupyter-archimedes will build correctly only if cairo happens to be compiled before archimedes. So this failure is not dune’s fault

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment