Skip to content
This repository

add opam package for pfff, just the parsing libraries #1300

Merged
merged 2 commits into from 5 months ago

2 participants

Yoann Padioleau Anil Madhavapeddy
Yoann Padioleau

Summary:
This is the Initial version of pfff opam package. It just installs
the different parsing libraries. In the next week I'll
try to update it to also install sgrep, spatch, stags,
scheck, and later codemap and codegraph. But for now,
let's just install the libraries. Js_of_ocaml recently
copy pasted the js parser in pfff just because it
was not easily accessible as a standalone library.

Test Plan:
put this package in my ~/testing repo
opam update testing
opam install pfff
=> it works, it installs pfff-xxx libraries
opam uninstall pfff
=> it works, it uninstalls pfff-xxx libraries

Yoann Padioleau add opam package for pfff, just the parsing libraries
Summary:
This is the Initial version of pfff opam package. It just installs
the different parsing libraries. In the next week I'll
try to update it to also install sgrep, spatch, stags,
scheck, and later codemap and codegraph. But for now,
let's just install the libraries. Js_of_ocaml recently
copy pasted the js parser in pfff just because it
was not easily accessible as a standalone library.

Test Plan:
put this package in my ~/testing repo
opam update testing
opam install pfff
 => it works, it installs pfff-xxx libraries
opam uninstall pfff
 => it works, it uninstalls pfff-xxx libraries
993e44d
Anil Madhavapeddy
Owner
Yoann Padioleau

I don't plan to split the pfff repo, so even if I make different packages, in the end they will all
fetch the pfff.tar.gz and compile most things.

Yoann Padioleau

Is it ok to have many packages that in the end use the same archive?

hhugo referenced this pull request in ocsigen/js_of_ocaml November 13, 2013
Open

rely on facebook/pfff libs to parse javascript #61

Anil Madhavapeddy
Owner

Multiple packages that use the same archive is just fine (Mirage does that too). You can have separate build commands for each one (to install just the library for example).

One tweak before merging this: could you add an OCaml version constraint to be greater than 3.12.1?

ocaml-version: [>="4.00.0"]

3.12.1 failing log here; https://travis-ci.org/ocaml/opam-repository/jobs/13946836

Yoann Padioleau

I love travis

Anil Madhavapeddy avsm merged commit 464a32d into from November 15, 2013
Anil Madhavapeddy avsm closed this November 15, 2013
Yoann Padioleau

When I do opam update; opam list |grep pfff I don't see anything.
Is it normal? How long it takes to get the package be reflected in the opam of the users?
Is it because I've installed opam a few months ago and it's not up to date with opam.ocaml.org
(opam update still metions opam.ocamlpro.com).

Anil Madhavapeddy
Owner
Yoann Padioleau

yep, it worked, opam upgrade process looks pretty solid :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 2 unique commits by 1 author.

Nov 13, 2013
Yoann Padioleau add opam package for pfff, just the parsing libraries
Summary:
This is the Initial version of pfff opam package. It just installs
the different parsing libraries. In the next week I'll
try to update it to also install sgrep, spatch, stags,
scheck, and later codemap and codegraph. But for now,
let's just install the libraries. Js_of_ocaml recently
copy pasted the js parser in pfff just because it
was not easily accessible as a standalone library.

Test Plan:
put this package in my ~/testing repo
opam update testing
opam install pfff
 => it works, it installs pfff-xxx libraries
opam uninstall pfff
 => it works, it uninstalls pfff-xxx libraries
993e44d
Nov 14, 2013
Yoann Padioleau add ocaml version check 6d0ed8f
This page is out of date. Refresh to see the latest.
14  packages/pfff.0.25.1/descr
... ...
@@ -0,0 +1,14 @@
  1
+Tools and APIs for program analysis, code visualization, refactoring
  2
+
  3
+pfff is a set of tools and APIs to perform some static analysis,
  4
+dynamic analysis, code visualizations, code navigations, or
  5
+style-preserving source-to-source transformations such as refactorings
  6
+on source code. For now the effort is focused on PHP but there is also
  7
+good support for C, C++, Java, HTML, Javascript, Css, and preliminary
  8
+support for Erlang, Python, C#, Lisp, Scheme, Haskell, OPA, Sql, and
  9
+even TeX. There is also very good support for OCaml and noweb
  10
+(literate programming) so that pfff can be used on the code of pfff
  11
+itself.
  12
+
  13
+For more information see https://github.com/facebook/pfff/wiki/Main
  14
+
15  packages/pfff.0.25.1/opam
... ...
@@ -0,0 +1,15 @@
  1
+opam-version: "1"
  2
+maintainer: "pad@fb.com"
  3
+homepage: "https://github.com/facebook/pfff/wiki/Main"
  4
+build: [
  5
+  ["./configure" "--novisual"]
  6
+  [make "depend"]
  7
+  [make]
  8
+  [make "opt"]
  9
+  [make "install-findlib"]
  10
+]
  11
+remove: [
  12
+  ["make" "uninstall-findlib"]
  13
+]
  14
+ocaml-version: [>= "4.00.1"]
  15
+depends: ["ocamlfind"]
2  packages/pfff.0.25.1/url
... ...
@@ -0,0 +1,2 @@
  1
+archive: "https://github.com/facebook/pfff/archive/v0.25.1.tar.gz"
  2
+checksum: "b0bc6f8d1b79c3b19e808921d2ec6949"
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.