-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package opam-bundle.0.4 #13064
Package opam-bundle.0.4 #13064
Conversation
☀️ All lint checks passed 713c0f4
☀️ Installability check (10044 → 10044) |
3bd4738
to
f659a7e
Compare
bug-reports: "https://github.com/AltGr/opam-bundle/issues" | ||
depends: [ | ||
"ocaml" | ||
"ocamlfind" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is ocamlfind just a build dependency (as ocaml)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, technically the package just installs a binary that doesn't manage OCaml sources or artifacts, so everything should be a build dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(but then there is always the old dilemma of "should it still get recompiled if e.g. there is a fix in opam-client
for a bug that affects it"... I guess in that case we could file a new release to force recompilation)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should keep cmdliner
and opam-client
out, as you actively use the libraries (and indeed want the package to be rebuilt in case of bugfixes), while ocaml and ocamlfind are only invoked externally during the build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made the change. I'll let the tests re-run before merging
f659a7e
to
c9e8bf9
Compare
opam-bundle.0.4
A tool that creates stand-alone source bundles from opam packages
opam-bundle is a command-line tool that, given a selection of packages,
generates a .tar.gz (and optionally a self-extracting) archive containing their
sources, and everything needed to bootstrap and compile them:
compile all the above, install the packages within a sandbox, and optionally
put wrapper scripts within your PATH
This is expected to be done as normal user, with constrained calls to
sudo
when needed for depexts and wrappers installation.
🐫 Pull-request generated by opam-publish v2.0.0