Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package opam-bundle.0.4 #13064

Merged
merged 2 commits into from
Dec 3, 2018
Merged

Conversation

AltGr
Copy link
Member

@AltGr AltGr commented Nov 29, 2018

opam-bundle.0.4

A tool that creates stand-alone source bundles from opam packages
opam-bundle is a command-line tool that, given a selection of packages,
generates a .tar.gz (and optionally a self-extracting) archive containing their
sources, and everything needed to bootstrap and compile them:

  • the sources of their dependencies
  • the sources of the chosen version of OCaml
  • the sources of opam
  • a set of scripts to bootstrap, check and install external dependencies,
    compile all the above, install the packages within a sandbox, and optionally
    put wrapper scripts within your PATH

This is expected to be done as normal user, with constrained calls to sudo
when needed for depexts and wrappers installation.



🐫 Pull-request generated by opam-publish v2.0.0

@camelus
Copy link
Contributor

camelus commented Nov 29, 2018

☀️ All lint checks passed 713c0f4
  • These packages passed lint tests: opam-bundle.0.4

☀️ Installability check (10044 → 10044)

@AltGr AltGr force-pushed the opam-publish-opam-bundle.0.4 branch 2 times, most recently from 3bd4738 to f659a7e Compare November 30, 2018 13:23
bug-reports: "https://github.com/AltGr/opam-bundle/issues"
depends: [
"ocaml"
"ocamlfind"
Copy link
Member

@mseri mseri Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ocamlfind just a build dependency (as ocaml)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, technically the package just installs a binary that doesn't manage OCaml sources or artifacts, so everything should be a build dependency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(but then there is always the old dilemma of "should it still get recompiled if e.g. there is a fix in opam-client for a bug that affects it"... I guess in that case we could file a new release to force recompilation)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should keep cmdliner and opam-client out, as you actively use the libraries (and indeed want the package to be rebuilt in case of bugfixes), while ocaml and ocamlfind are only invoked externally during the build

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the change. I'll let the tests re-run before merging

@AltGr AltGr force-pushed the opam-publish-opam-bundle.0.4 branch from f659a7e to c9e8bf9 Compare December 3, 2018 09:01
@mseri mseri merged commit b199ec7 into ocaml:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants