Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added packages/pardi/pardi.1.0.0/opam #14415

Merged
merged 3 commits into from Jul 2, 2019
Merged

Conversation

UnixJunkie
Copy link
Contributor

The distributed execution mode is not yet supported,
but should come soon.

@mseri
Copy link
Member

mseri commented Jul 1, 2019

Does this need a lower bound on parany 6.0.0 ?

Co-Authored-By: Marcello Seri <mseri@users.noreply.github.com>
@UnixJunkie
Copy link
Contributor Author

UnixJunkie commented Jul 2, 2019

Yes, a lower bound version constraint on parany was needed.
Thanks for having provided it.

@mseri
Copy link
Member

mseri commented Jul 2, 2019

The ocaml 4.03 and 4.04 versions are failing with

#=== ERROR while compiling pardi.1.0.0 ========================================#
# context              2.0.4 | linux/x86_64 | ocaml-base-compiler.4.03.0 | pinned(https://github.com/UnixJunkie/pardi/archive/v1.0.0.tar.gz)
# path                 ~/.opam/4.03/.opam-switch/build/pardi.1.0.0
# command              ~/.opam/4.03/bin/dune build -p pardi -j 71
# exit-code            1
# env-file             ~/.opam/log/pardi-15-a54edf.env
# output-file          ~/.opam/log/pardi-15-a54edf.out
### output ###
# Info: creating file dune-project with this contents:
# | (lang dune 1.10)
# | (name pardi)
# 
#     ocamlopt src/.pardi.eobjs/native/sorted_queue.{cmx,o} (exit 2)
# (cd _build/default && /home/opam/.opam/4.03/bin/ocamlopt.opt -w -40 -g -I src/.pardi.eobjs/byte -I src/.pardi.eobjs/native -I /home/opam/.opam/4.03/lib/batteries -I /home/opam/.opam/4.03/lib/bytes -I /home/opam/.opam/4.03/lib/dolog -I /home/opam/.opam/4.03/lib/equeue -I /home/opam/.opam/4.03/lib/minicli -I /home/opam/.opam/4.03/lib/netcamlbox -I /home/opam/.opam/4.03/lib/netmulticore -I /home/opam/.opam/4.03/lib/netplex -I /home/opam/.opam/4.03/lib/netstring -I /home/opam/.opam/4.03/lib/netsys -I /home/opam/.opam/4.03/lib/num -I /home/opam/.opam/4.03/lib/ocaml/threads -I /home/opam/.opam/4.03/lib/parany -I /home/opam/.opam/4.03/lib/rpc -intf-suffix .ml -no-alias-deps -o src/.pardi.eobjs/native/sorted_queue.cmx -c -impl src/sorted_queue.ml)
# File "src/sorted_queue.ml", line 20, characters 8-19:
# Error: Unbound value Ht.find_opt
# Hint: Did you mean find_all?

Maybe some other lower bound is missing?

because of the unwise use of Hashtbl.find_opt...
this constraint will be removed in future releases
@UnixJunkie
Copy link
Contributor Author

Yes, I added one.

@UnixJunkie
Copy link
Contributor Author

Ok, CI tests looks all green now.

@mseri
Copy link
Member

mseri commented Jul 2, 2019

Thanks for the help

@mseri mseri merged commit 72318fa into ocaml:master Jul 2, 2019
@UnixJunkie UnixJunkie deleted the pardi_100 branch July 2, 2019 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants