-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
omp 1.4.0: refresh checksum due to changed upstream tarball #15294
Conversation
unrelated to the checksum fix, but it's broken on 4.02, ..., 4.07 due to:
|
From https://github.com/ocaml-ppx/ocaml-migrate-parsetree/releases it seem that: omd 1.4.0 works only with 4.08, 4.09 and 4.10 So I'll add bounds for >= 4.08. |
Merging this quickly to unlock other CIs -- the revdeps errors are unrelated. |
FWIW here's a diff of the old tarball (231fbdc205187b3ee266b535d9cfe44b599067b2f6e97883c782ea7bb577d3b8) and the new one. |
See #15300 for a new tentative fix. I completly forgot that the previous archive would be available in the cache, so I followed @hannesm's advice and modified the url instead of picking a new archive. @diml this will need some more investigation from your side to understand which archive you really want to release for 1.4.0 (the previous one or the new one :p) |
I think I know what happened here -- dune-release will overwrite an existing tag if the CHANGES file hasn't been updated. The same happened for |
I don't agree with the fix, 1.4.0 original compiled find on 4.07 for example. 1.4.0 with new checksum does not - I believe it is some commit between 1.4.0 tag and 1.4.1 tag. I think opam repo should revert to previous archive and previous checksum (that's what I did in local opam mirror). |
that page was modified yesterday, 1.4.0 was released to opam in |
- A new ocaml-migrate-parsetree.1.4.0 was released, replacing the old 1.4.0 with new code. This was rejected by the checksum test. Fixed by updating to the latest opam-repository. See: ocaml/opam-repository#15294 - The latest opam-repository pulls in mirage 3.7, which doesn't work (`No available version of mirage-clock satisfies the constraints`), so pin the previous mirage 3.5.2 version instead.
- A new ocaml-migrate-parsetree.1.4.0 was released, replacing the old 1.4.0 with new code. This was rejected by the checksum test. Fixed by updating to the latest opam-repository. See: ocaml/opam-repository#15294 - The latest opam-repository pulls in mirage 3.7, which doesn't work (`No available version of mirage-clock satisfies the constraints`), so pin the previous mirage 3.5.2 version instead. - Mirage now generates `.merlin`, so remove it from Git.
Just catching up on emails. I indeed overwrote the 1.4.0 release of omp by accident (cf #15280 (comment)). I propose to restore the 1.4.0 release of omp by restoring the original archive. Let me know if that's a bad idea for some reason. |
@diml that's a good idea, in the meantime we had pointed the opam file to the opam cache sources of the old tarball |
For the record, I agree, it was a mistake that I have fixed it a few hours later with #15300 |
fixes #15281