Result 1.5 - improved 4.08 compatibility #15853
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release mainly addresses janestreet/result#8, which is that
Result
fromresult
shadowsResult
fromStdlib
, which is available starting from 4.08.Stdlib.Result
has more values declared and a different type name, and all of these become inaccessible because of the shadowing, unless one consistently writesStdlib.Result
instead of justResult
. This was a great annoyance ifresult
appeared anywhere in the dependency graph of a project, especially if it was introduced at a late stage in development, which could cause a large amount of code to break.EDIT: This release makes
Result
fromresult
includeStdlib.Result
on OCaml >= 4.08.cc @diml