Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result 1.5 - improved 4.08 compatibility #15853

Merged
merged 1 commit into from Feb 26, 2020
Merged

Conversation

aantron
Copy link
Contributor

@aantron aantron commented Feb 17, 2020

This release mainly addresses janestreet/result#8, which is that Result from result shadows Result from Stdlib, which is available starting from 4.08.

Stdlib.Result has more values declared and a different type name, and all of these become inaccessible because of the shadowing, unless one consistently writes Stdlib.Result instead of just Result. This was a great annoyance if result appeared anywhere in the dependency graph of a project, especially if it was introduced at a late stage in development, which could cause a large amount of code to break.

EDIT: This release makes Result from result include Stdlib.Result on OCaml >= 4.08.

cc @diml

@aantron
Copy link
Contributor Author

aantron commented Feb 17, 2020

Please consider this as WIP until we address janestreet/result#9 (comment).

@camelus
Copy link
Contributor

camelus commented Feb 17, 2020

Commit: 26d5784

I made an error retrieving the post by the user, sorry about that

☀️ All lint checks passed 26d5784
  • These packages passed lint tests: result.1.5

@aantron
Copy link
Contributor Author

aantron commented Feb 25, 2020

Just repeating the comment from #15893: I believe this can be merged, as only one revdep failure was due to result; that was the test cases of containers.2.7, which were constrained in #15893. There are newer releases of containers, so nothing needs to be done upstream.

@kit-ty-kate kit-ty-kate merged commit 1bfc714 into ocaml:master Feb 26, 2020
@kit-ty-kate
Copy link
Member

Thanks (sorry for the huge delay)

@aantron
Copy link
Contributor Author

aantron commented Feb 26, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants