Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename ppx_inline_test 0.13.1 to ppx_inline_test v0.13.1 #16097

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Mar 29, 2020

otherwise it'll never be selected for installation //cc @diml //cc #15933

@hannesm
Copy link
Member Author

hannesm commented Mar 29, 2020

but unfortunately even with ppx_inline_test pinned to 0.13.1 I get in my _build/install/dns/META the following entries (after a dune build --profile=release):

            ppx_expect.collector
            ppx_expect.config
            ppx_here.runtime-lib
            ppx_inline_test.runtime-lib

@kit-ty-kate
Copy link
Member

Sorry for not seeing that the first time. Thanks!

@kit-ty-kate kit-ty-kate merged commit 27f67ae into ocaml:master Mar 30, 2020
@hannesm hannesm deleted the ppx_inline_version branch March 30, 2020 10:53
@ghost
Copy link

ghost commented Mar 30, 2020

Thanks for the fix @hannesm! Doing a minor release of these packages is always a bit tedious because of the "v" prefix. We are currently missing the ability to tell dune-release to keep the "v" prefix once and for all for a given project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants