Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camlidl: fix bytecode link #16179

Closed
wants to merge 2 commits into from
Closed

camlidl: fix bytecode link #16179

wants to merge 2 commits into from

Conversation

ygrek
Copy link
Contributor

@ygrek ygrek commented Apr 10, 2020

No description provided.

@camelus
Copy link
Contributor

camelus commented Apr 10, 2020

Commit: eb33827

A pull request by opam-seasoned @ygrek.

☀️ All lint checks passed eb33827
  • These packages passed lint tests: camlidl.1.07

☀️ Installability check (+0)

🌤️ 2 ignored non-opam files:
  • packages/camlidl/camlidl.1.07/files/META
  • packages/camlidl/camlidl.1.07/files/disable-fatal-warn-31.diff

@ygrek
Copy link
Contributor Author

ygrek commented Apr 10, 2020

 2 ignored non-opam files:
packages/camlidl/camlidl.1.07/files/META
packages/camlidl/camlidl.1.07/files/disable-fatal-warn-31.diff

I am not sure what that means, not clean state on CI?

@kit-ty-kate
Copy link
Member

one of the revdeps (lutin.2.70.4) fails with this error message. Is it expected?

# Error: Error on dynamically loaded library: /home/opam/.opam/4.10/lib/stublibs/dllcamlidl.so: /home/opam/.opam/4.10/lib/stublibs/dllcamlidl.so: undefined symbol: IID_IUnknown
# Command exited with code 2.

@ygrek
Copy link
Contributor Author

ygrek commented Apr 11, 2020

It was a bug in camlidl, it is now fixed in git. Technically it means that camlidl in bytecode is not useable in current release (and so the change in META in this PR is not effective, but it will help with pins to dev-depo).

(I believe no camlidl revdep was buildable in bytecode previously)

@kit-ty-kate
Copy link
Member

Should we close this PR then?

@ygrek
Copy link
Contributor Author

ygrek commented Apr 13, 2020

The current fix is not making situation worse and can be postponed till next camlidl release, true. OTOH it helps people doing pin --dev-repo camlidl.
Your call :)

@kit-ty-kate
Copy link
Member

opam-repository is not really made to encourage use opam pin --dev, I'd much rather not break anything and wait for the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants