Experimental fix for mirage/mirage#221 #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leaves a stray binary after an uninstall, but fixes the situation where the `mirage` binary attempts to upgrade itself (due to invoking OPAM, which installs some optional dependencies, which then proceed to try and recompile mirage). The only long-term fix is to lift `mirage` into being a host-level tool and not tracked by the same tool it uses to install libraries, but for the moment renaming the active `mirage` binary to `mirage.old` on uninstall should do the trick.
|
@samoht, thoughts? |
|
why not simply remove the binary ? |
The uninstall simply wasn't removing the binary before.
samoht
added a commit
that referenced
this pull request
Feb 13, 2014
Experimental fix for mirage/mirage#221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leaves a stray binary after an uninstall, but fixes the
situation where the
miragebinary attempts to upgrade itself(due to invoking OPAM, which installs some optional dependencies,
which then proceed to try and recompile mirage).
The only long-term fix is to lift
mirageinto being a host-leveltool and not tracked by the same tool it uses to install libraries,
but for the moment renaming the active
miragebinary tomirage.oldon uninstall should do the trick.