Add ocaml-option-nnpchecker #18021
Add ocaml-option-nnpchecker #18021
Conversation
|
Commit: a6daaf4 A pull request by opam-seasoned @dra27. 🌤️ opam-lint warnings a6daaf4
☀️ Installability check (+1)
|
| depends: [ | ||
| "ocaml-variants" {post & >= "4.12.0~"} | ||
| ] | ||
| available: arch = "x86_64" & (os = "linux" | os = "macos" | os = "openbsd" | os = "freebsd") |
There was a problem hiding this comment.
is the option really specific to those platforms and architecture?
There was a problem hiding this comment.
It is indeed, see https://github.com/ocaml/ocaml/blob/trunk/configure.ac#L1727-L1735. Technically msvc64 and solaris are also included, but I know we don't have an encoding for msvc64 and I haven't got access to Solaris to see what uname -s does (I think it's SunOS, but I have no way to check!)
There was a problem hiding this comment.
Perhaps @mtelvers still has a Solaris box gathering dust somewhere? 😉
There was a problem hiding this comment.
@dra27 I have recovered my SparcStation 20 from deep storage and even found a Sun 13W3-M to VGA adapter but sadly none of my monitors accept the resolution/timing.
There was a problem hiding this comment.
@dra27 It's SunOS -- the Wikipedia page has a convenient list: https://en.wikipedia.org/wiki/Uname
There was a problem hiding this comment.
Ta, @avsm! A handy list (if less fun than persuading Mark to try building OCaml on a 1994 Sun Workstation 😉). I've pushed an amended version with os = "sunos" too (opam normalises with lowercase_ascii)
dra27
force-pushed
the
ocaml-option-nnpchecker
branch
from
3e4516e
to
a6daaf4
Compare
|
Thanks! |
This PR adds
ocaml-option-nnpcheckerto trigger the--enable-naked-pointers-checkeroption in OCaml 4.12+I haven't updated ocaml-config to emulate a switch name for this - I'm not sure we particularly want one, but it can be added if required.
I have intentionally edited the existing options as they only apply to a beta release - in future we'd expect to bump the versions.
cc @Octachron