Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] path_glob (0.2) #18054

Merged
merged 2 commits into from Jan 28, 2021
Merged

Conversation

gasche
Copy link
Member

@gasche gasche commented Jan 28, 2021

CHANGES:

Initial publication of the package, extracted from the ocamlbuild sources.
The library is named 'path_glob'.

@gasche
Copy link
Member Author

gasche commented Jan 28, 2021

Note mostly for myself, but just in case: this is my first time using dune-release, and it is quite nice. Here is what I had to do to get the release out:

# I manually created a tag
git tag 0.2

# ask dune-release to create the release archive (giving the tag manually)
dune-release distrib --tag 0.2
  # Note: this creates an archive _build/path_glob-0.2.tbz

# upload the archive through Gitlab Pages, manually
git checkout pages
cp _build/path_glob-0.2.tbz docs/releases/
git add docs/releases/path_glob-0.2.tbz
git commit -m "dune-release archive for path_glob 0.2"
git push
git checkout main

# review the about-to-be-generated opam description for the release
#  (we need to pass --dist-uri because dune-release does not know
#   about the gitlab.com Pages URL convention)
dune-release opam pkg --tag 0.2 --dist-uri=https://gasche.gitlab.io/path_glob/releases/path_glob-0.2.tbz
less _build/path_glob.0.2/opam

# everything good, submit the PR through my local fork
dune-release opam submit --tag 0.2 -l ~/Prog/opam-repository --dist-uri=https://gasche.gitlab.io/path_glob/releases/path_glob-0.2.tbz

@gasche gasche force-pushed the release-path_glob-0.2 branch 2 times, most recently from 5a4d58f to a641292 Compare January 28, 2021 08:39
@gasche
Copy link
Member Author

gasche commented Jan 28, 2021

(I realize that the doc URL I put in the opam-metadata is slightly wrong, so I will force-update the PR shortly.)

CHANGES:

Initial publication of the package, extracted from the ocamlbuild sources.
The library is named 'path_glob'.
@gasche
Copy link
Member Author

gasche commented Jan 28, 2021

(The url is now fixed -- re-running the same steps again force-pushes to this PR, so it just works.)

@camelus
Copy link
Contributor

camelus commented Jan 28, 2021

Commit: 1a36173

A pull request by opam-seasoned @gasche.

☀️ All lint checks passed 1a36173
  • These packages passed lint tests: path_glob.0.2

☀️ Installability check (+1)
  • new installable packages (1): path_glob.0.2

@gasche
Copy link
Member Author

gasche commented Jan 28, 2021

(I added a dev-repo in my in-development opam file, but I will not rerun the release process for this.)

@gasche
Copy link
Member Author

gasche commented Jan 28, 2021

Thanks @kit-ty-kate, will reproduce downstream.

@kit-ty-kate
Copy link
Member

Thanks a lot!

@kit-ty-kate kit-ty-kate merged commit 2967e1c into ocaml:master Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants