-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ocaml-src.4.13.0 #18229
Add ocaml-src.4.13.0 #18229
Conversation
Commit: 7919c82 Good to see you Madam. 🌤️ opam-lint warnings 7919c82
☀️ Installability check (+1)
🌤️ 1 ignored non-opam files:
|
I am in favor of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm generally fine with opam-repository tracking ocaml trunk with git urls, so that our metadata is consistent.
extra-files: ["META" "md5=a86cbc1fb202e11ff24cde77754c9d93"] | ||
url { | ||
# TODO: Update on each alpha/beta/rc releases and one last time for the final release | ||
src: "https://github.com/ocaml/ocaml/archive/trunk.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a git
src so that opam update
will pick up on upstream commits and track them correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we do that, we need to do the same thing in ocaml-variants.4.13.0+trunk
as it is not currently the case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are compiler packages, whereas this is a library package (that is, used as a dependency in various Mirage builds).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(note that it's fine to change the compiler packages too, but that's a separate change unrelated to this one)
I don't know what @Octachron's opinion is, but I'm slightly uncomfortable with version 4.13.0 of the OCaml sources appearing to be published! Can it be a simple matter of it being |
Yes good idea, adding |
Looks reasonable to me. As others have said, having the version be What is the purpose of the |
IIRC it is needed for ocamlfind to consider the package being installed, from ocaml-freestanding Makefile: |
I agree with |
Ah, thanks for looking at this properly - I had a memory there was a reason we didn't always drop the ".0", and this is it! Two thoughts:
|
Mirage packages always get left behind because of the lack of ocaml-src package in opam-repository.
This proposal creates a placeholder package to update at each alpha/beta/rc (with their respective checksums) and one last time for the final release.
@Octachron @hannesm @mato what do you think?