Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ 0install 2.6.2 #1863

Closed
wants to merge 1 commit into from
Closed

+ 0install 2.6.2 #1863

wants to merge 1 commit into from

Conversation

ygrek
Copy link
Contributor

@ygrek ygrek commented Apr 5, 2014

No description provided.

@avsm
Copy link
Member

avsm commented Apr 5, 2014

Thanks! Are these local patches upstreamable (or already so)? /cc @talex5

@ygrek
Copy link
Contributor Author

ygrek commented Apr 5, 2014

I don't know why upstream uses lib/0install.net for plugins and couldn't figure out how to make opam install the files there instead of lib/0install, without resorting to misc section. Looks like exactly a situation that warrants a local patch.

@talex5
Copy link
Contributor

talex5 commented Apr 5, 2014

It might also be worth noting that the OCaml API isn't fixed (so you shouldn't use it as a library yet). However, the command-line interface, JSON interface, and XML formats will remain backwards compatible.

@talex5
Copy link
Contributor

talex5 commented Apr 5, 2014

Also, I suspect the GUI will be broken on OS X, as it requires the Lwt fixes from ocsigen/lwt#25 (which aren't in 2.4.4).

@avsm
Copy link
Member

avsm commented Apr 6, 2014

@ygrek: local patches are fine, but it's preferred to incorporate them upstream in the longer term (i.e. expose a configure option OPAM can use, or something else). The packaging hooks are also of use to other OSes, usually.

Anyway, not a blocker for this version, so I'm merging now.

@avsm avsm mentioned this pull request Apr 6, 2014
@avsm avsm closed this in 6b0f826 Apr 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants