New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slug: URL-safe slug generator #19012
Conversation
cc @thangngoc89 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things to update. Can you make the changes upstream?
EDIT: Let's wait for the CI and see if we need more lower bounds
Co-authored-by: Anil Madhavapeddy <anil@recoil.org>
I updated upstream with all the suggested changes |
Can you please add a license field with the correct license in spdx format? |
@mseri I added it upstream here but I don't have write access to this PR |
Good to merge now! |
Consider announcing the release on discuss.ocaml.org :) |
Thank you very much. |
In summary,
returns
"some-page-title"
which is more suitable for use in URLs. Slug offers several options for tweaking the exact behavior.
From the README:
This library turns title into URL-safe slug with support for non-latin characters.
This library uses algorithm and data from node-slugify