-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport glibc 2.34 fix to 3.07-4.12 #19855
Conversation
e99bd9c
to
3574a4a
Compare
pending upon ocaml/ocaml#10726 |
Also hope for 4.08 |
Any ETA? I need to compile some deps using 4.12.1 on Ubuntu 21.04 |
@Corfucinas - you can temporarily add my branch, if it helps, with In terms of ETA, the remaining upstream PR is slated for 4.14, so it should be no later than the first alpha of 4.14.0. |
Fedora 35 (released Nov 2021) also uses glibc 2.34 |
That PR has been merged now 🎉 |
Already applied in other packages.
The additional patches for these compilers no longer exist.
3574a4a
to
dbdb3bb
Compare
This remote should be usable for anyone wishing to test compilers on Ubuntu 21.10+ etc. |
dbdb3bb
to
30a58fc
Compare
Closing temporarily (testing 300 compilers and their reverse dependencies is making the CI blow up). It’ll be reopened shortly I promise |
30a58fc
to
5020df8
Compare
Two updates:
|
e41dc95
to
cee6ed2
Compare
@dra27 is this PR ready? |
Awaiting the patches being pushed to ocaml/ocaml (last task above). Hopefully tomorrow! |
fafa696
to
0503533
Compare
This PR should be good to go 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
@@ -40,3 +40,20 @@ url { | |||
checksum: "md5=4f3906e581181c5435078ffe3e485e3f" | |||
} | |||
available: !(os = "macos" & arch = "arm64") | |||
license: "QPL-1.0 AND LGPL-2.1-or-later WITH OCaml-LGPL-linking-exception" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should be only LGPL-2.1-or-later WITH OCaml-LGPL-linking-exception
but it doesn’t matter, we can always fix it later.
With the release of Ubuntu 21.10 (Impish), we're starting to get (more) distros with Glibc 2.34+ and therefore ocaml/ocaml#10250 is biting. I think this is as with the GCC 10 changes - we need to back-port in opam-repository in order to keep old compilers building with newer distros.
I propose pushing ocaml/ocaml#10266 to the maintenance tips of the 4.10, 4.11 and 4.12 branches. The back-port to these versions is trivial. I'll aim to confirm this with @Octachron later and, assuming they get pushed upstream I'll amend this PR to point to ocaml/ocaml instead of dra27/ocaml.
I'm opening the draft for now in order to allow the cluster to test these packages.
I have not updated:
The back-port to 4.09 and earlier is not as trivial: the machinery was changed in ocaml/ocaml#8670 to fix stack overflow in systhreads, so malloc'ing the alternate stack needs extricating from that. I intend to open a PR against 4.09 for that, just to allow (hopefully brief) review. Once that's merged to the 4.09 maintenance branch, I'd then aim to push that to previous branches and will then open another opam-repository PR like this one.
Patches prepared. Remaining tasks:
opam source
on all packagesopam switch create
on all the ocaml-base-compiler packages and the+options
variants`