Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] curses (1.0.10) #20074

Merged
merged 3 commits into from
Nov 26, 2021
Merged

[new release] curses (1.0.10) #20074

merged 3 commits into from
Nov 26, 2021

Conversation

mbacarella
Copy link
Contributor

Bindings to ncurses

CHANGES:
  • Updated to dune-lang 2.7, so that we don't have that generated .opam file
    bug anymore.

CHANGES:

* Updated to dune-lang 2.7, so that we don't have that generated .opam file
  bug anymore.
@mbacarella
Copy link
Contributor Author

Actual changes

  • Fix build on Arch Linux, and also more broadly on MacOS and Windows

@kit-ty-kate
Copy link
Member

For the record the additional dependency is required because it failed with Homebrew:

#=== ERROR while compiling curses.1.0.10 ======================================#
# context              2.1.1 | macos/x86_64 | ocaml-system.4.13.1 | pinned(https://github.com/mbacarella/curses/releases/download/1.0.10/curses-1.0.10.tbz)
# path                 ~/.opam/default/.opam-switch/build/curses.1.0.10
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p curses -j 11 @install
# exit-code            1
# env-file             ~/.opam/log/curses-71814-168ac5.env
# output-file          ~/.opam/log/curses-71814-168ac5.out
### output ###
#     discover _config.h,c_flags.sexp,c_library_flags.sexp,config.ml (exit 1)
# (cd _build/default && ./discover.exe)
# which: pkg-config
# -> not found
# Error: 'pkg-config' missing

@kit-ty-kate
Copy link
Member

Is the failure on Ubuntu 18.04 expected?

-   ocamlmklib dllcurses_stubs.so,libcurses_stubs.a (exit 2)
- (cd _build/default && /home/opam/.opam/4.13/bin/ocamlmklib.opt -g -o curses_stubs ml_curses.o -lncursesw)
- /usr/bin/ld: cannot find -lncursesw
- collect2: error: ld returned 1 exit status

@mbacarella
Copy link
Contributor Author

Is the failure on Ubuntu 18.04 expected?

No. It built successfully with ocaml-setup ubuntu-latest? https://github.com/mbacarella/curses/runs/4279233327?check_suite_focus=true

@kit-ty-kate
Copy link
Member

Is the failure on Ubuntu 18.04 expected?

No. It built successfully with ocaml-setup ubuntu-latest? https://github.com/mbacarella/curses/runs/4279233327?check_suite_focus=true

yes it sucessfully built with 20.04 here as well. Is that something you want to do something about or should we ignore the error? If so do you know the origin of the problem?

@mbacarella
Copy link
Contributor Author

mbacarella commented Nov 21, 2021

I'm content to ignore the Ubuntu 18 build error until someone complains, especially since it works in future Ubuntu releases.

Linking to ncurses is kind of a mess due to UNIX history and I've already sunk much more time into resolving this in a cross-platform way (to otherwise good success) than I had budgeted.

@kit-ty-kate
Copy link
Member

Thanks! Sorry for the wait

@kit-ty-kate kit-ty-kate merged commit f00176f into ocaml:master Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants