Package libbinaryen.106.0.0 #21330
Merged
Package libbinaryen.106.0.0 #21330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lol, it looks like our |
|
Fails on arm32 and x86_32 |
mseri
reviewed
May 5, 2022
| bug-reports: "https://github.com/grain-lang/libbinaryen/issues" | ||
| depends: [ | ||
| "conf-cmake" {build} | ||
| "dune" {>= "2.9.1" & < "3.0.0"} |
There was a problem hiding this comment.
Why such a strict bound is needed?
There was a problem hiding this comment.
Dune 3 has an implicit dependency on opam on the system. In places you don't have opam, it fails. I want to ensure our package works in different contexts without needing to know that trivia.
Dune merged some patches this week that are yet-to-be-released. Once it works without opam, I'll open up the range.
mseri
reviewed
May 5, 2022
Co-authored-by: Marcello Seri <mseri@users.noreply.github.com>
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libbinaryen.106.0.0Libbinaryen packaged for OCaml
106.0.0 (2022-05-04)
⚠ BREAKING CHANGES
Features
🐫 Pull-request generated by opam-publish v2.0.3