Tls 016 revdeps2 #23315
Merged
Tls 016 revdeps2 #23315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
reviewed
Feb 14, 2023
packages/sihl/sihl.0.1.10/opam
Outdated
| @@ -37,6 +37,7 @@ depends: [ | |||
| "alcotest-lwt" {>= "1.2.0" & < "3.0.0" & with-test} | |||
| "cohttp-lwt-unix" {>= "2.5.1"& with-test} | |||
| "odoc" {with-doc} | |||
| "mirage-crypto" | |||
There was a problem hiding this comment.
I don't think this is the right fix here. sihl uses the Mirage_crypto module but only implicitly through tls and does not require it in its dune file.
The only fix possible here I think is to add < "0.16.0" to the tls dependency above
kit-ty-kate
force-pushed
the
tls-016-revdeps2
branch
from
b32c9db
to
74bc3a9
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
third part of fixing revdeps #23311