Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github CI actions #23777

Closed
wants to merge 1 commit into from
Closed

Github CI actions #23777

wants to merge 1 commit into from

Conversation

toots
Copy link
Contributor

@toots toots commented May 11, 2023

Hi!

I noticed that the official CI is currently being rebuilt so I dusted off my old #20322 PR. Hopefully, this can help move things forward while the regular CI is rebuilt?

The actions do not include everything that the official CI supports, in particular extra features and architectures but it does check against a bunch of OCaml compiler versions as well as platforms and revdeps, hopefully enough to start merging some PRs!

It should also be possible to cherry-pick the one commit from this PR, add it to another pending PR, check the result of the actions and remove it before the merge if y'all don't want to include the files in the main branch. Here's an example with the pending ogg.0.7.4: https://github.com/ocaml/opam-repository/actions/runs/4942730965

Example run with two packages (faad.0.4.0 and (artificially picked) liquidsoap.2.0.1): https://github.com/savonet/opam-repository/actions/runs/4942469715

I tested it against the Janest PR #23742 but, oh my, no this one is still way too big for it.. See: https://github.com/savonet/opam-repository/actions/runs/4942483639 🙂

@Niols
Copy link
Contributor

Niols commented May 11, 2023

The CI on this very PR reports the following “annotations”:

Error when evaluating 'strategy' for job 'compilers'. .github/workflows/ci.yml (Line: 50, Col: 18): Matrix vector 'package' does not contain any values

Should we be worried? I suppose this might only happen when there are no packages to check, in which case the CI does what is expected. (That is not much.)

@toots
Copy link
Contributor Author

toots commented May 11, 2023

The CI on this very PR reports the following “annotations”:

Error when evaluating 'strategy' for job 'compilers'. .github/workflows/ci.yml (Line: 50, Col: 18): Matrix vector 'package' does not contain any values

Should we be worried? I suppose this might only happen when there are no packages to check, in which case the CI does what is expected. (That is not much.)

The current setup doesn't account for the empty state, i.e. when there are no changed packages (also I think no revdeps).

I still agree with #20322 decision, having two CIs might be a maintenance burden so I didn't polish that part. However, the execution with actual changed packages are potentially useful at the moment as a substitute.

@smorimoto
Copy link
Member

I'm concerned that this will put pressure on the CI parallelism of the OCaml organisation and delay the CI of other projects. We've already experienced some decent CI delays for GitHub Actions, and I think the opam-repository has been well-tested with ocurrent, so I'm not sure how much benefit there would be in adding GitHub Actions to this. GitHub has increased the parallelism for us once, but it's still not enough. I think we probably need as much as the Rust team... (Of course, more optimisation, and so on!)

@mseri
Copy link
Member

mseri commented May 15, 2023

Thanks for thinking about this. The CI is back, I am going to close this for now. But I will raise the point at pur next meeting

@mseri mseri closed this May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants