Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package delimcc_of_fxhandler.0.1 #23972

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

kayceesrk
Copy link
Contributor

delimcc_of_fxhandler.0.1

Delimited control primitives on top of effect handlers
Delimited control primitives on top of effect handlers



🐫 Pull-request generated by opam-publish v2.2.0

Co-authored-by: Anil Madhavapeddy <anil@recoil.org>
@mseri
Copy link
Member

mseri commented Jun 21, 2023

Something strange is going on:


#=== ERROR while compiling delimcc_of_fxhandler.0.1 ===========================#
# context              2.2.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.5.0.0 | pinned(https://github.com/kayceesrk/delimcc_of_fxhandler/archive/refs/tags/0.1.tar.gz)
# path                 ~/.opam/5.0/.opam-switch/build/delimcc_of_fxhandler.0.1
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p delimcc_of_fxhandler -j 255 @install
# exit-code            1
# env-file             ~/.opam/log/delimcc_of_fxhandler-7-f6ec2e.env
# output-file          ~/.opam/log/delimcc_of_fxhandler-7-f6ec2e.out
### output ###
# File "/home/opam/.opam/5.0/lib/multicont/dune-package", line 1, characters 0-846:
# 1 | (lang dune 3.0)\n(name multicont)\n(version 1.0.0~rc.3)\n(sections (lib .) (stublibs ../../stublibs) (doc ../../doc/multicont))\n(files\n (lib\n  (multicont.mli\n   multicont.a\n   multicont.cma\n   multicont.cmi\n   multicont.cmti\n   multicont.cmx\n   multicont.cmxa\n   libmulticont.a\n   libmulticontopt.a\n   META\n   dune-package))\n (stublibs\n  (dllmulticont.so\n   dllmulticontopt.so))\n (doc\n  (LICENSE\n   README.md)))\n(library\n (name multicont)\n (synopsis "Multi-shot continuations in OCaml")\n (kind normal)\n (archives (byte multicont.cma) (native multicont.cmxa))\n (foreign_archives libmulticont.a libmulticontopt.a)\n (native_archives multicont.a)\n (main_module_name Multicont)\n (modes byte native)\n (modules\n  (singleton\n    (name Multicont)\n    (obj_name multicont)\n    (visibility public)\n    (impl)\n    (intf))))
#     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# Error: Invalid first line, expected: (lang <lang> <version>)
# -> required by library "delimcc_of_fxhandler" in _build/default/lib
# -> required by _build/default/META.delimcc_of_fxhandler
# -> required by _build/install/default/lib/delimcc_of_fxhandler/META
# -> required by _build/default/delimcc_of_fxhandler.install
# -> required by alias install

@kayceesrk
Copy link
Contributor Author

The errors are in the multicont library, one of the dependencies of the current library. What's the expectation here regarding dependencies failing?

@mseri
Copy link
Member

mseri commented Jun 22, 2023

Yes, I don’t consider it a blocker for this PR.

The PR is still open because I needed to check if my fix for 5e lower bounds was enough. I am rerunning those two tests now that it is merged and if they pass, I will merge

@mseri
Copy link
Member

mseri commented Jun 22, 2023

All good, thanks!

@mseri mseri merged commit 78aa037 into ocaml:master Jun 22, 2023
1 of 2 checks passed
@kayceesrk
Copy link
Contributor Author

Thanks!

@avsm
Copy link
Member

avsm commented Jun 22, 2023

@dhil, the ocaml-multicont library seems to be playing gymnastics with dune :-)
https://github.com/dhil/ocaml-multicont/blob/master/Makefile#L98

@dhil
Copy link
Contributor

dhil commented Jun 22, 2023

ah rip. I looked into this in the past, but I am afraid I don't understand dune well enough to get it to produce two different linkable libraries from the same source. The C source differs depending on whether the target is native or bytecode. Any pointers to help would be appreciated.

@dhil
Copy link
Contributor

dhil commented Jun 23, 2023

Hopefully fixed by #23988.

mseri pushed a commit that referenced this pull request Jun 29, 2023
CHANGES:

This release is a purely administrative release which ports the build
infrastructure to [dune](https://github.com/ocaml/dune) in order to
resolve the reported build issues
(e.g. #23972).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants