Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lablgl.1.07 uses camlp5 #24020

Merged
merged 1 commit into from
Jun 28, 2023
Merged

lablgl.1.07 uses camlp5 #24020

merged 1 commit into from
Jun 28, 2023

Conversation

emillon
Copy link
Contributor

@emillon emillon commented Jun 28, 2023

In #24007:

#=== ERROR while compiling lablgl.1.07 ========================================#
# context              2.2.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.4.14.1 | file:///home/opam/opam-repository
# path                 ~/.opam/4.14/.opam-switch/build/lablgl.1.07
# command              ~/.opam/opam-init/hooks/sandbox.sh build make INSTALLDIR=/home/opam/.opam/4.14/lib/lablgl glut
# exit-code            2
# env-file             ~/.opam/log/lablgl-7-dde7f3.env
# output-file          ~/.opam/log/lablgl-7-dde7f3.out
### output ###
# cd src && make all LIBDIR="`ocamlc -where`"
# make[1]: Entering directory '/home/opam/.opam/4.14/.opam-switch/build/lablgl.1.07/src'
# camlp5o pr_o.cmo -impl var2def.ml4 -o var2def.ml
# make[1]: camlp5o: No such file or directory
# make[1]: *** [../Makefile.common:64: var2def.ml] Error 127
# make[1]: Leaving directory '/home/opam/.opam/4.14/.opam-switch/build/lablgl.1.07/src'
# make: *** [Makefile:12: lib] Error 2

In ocaml#24007:

    #=== ERROR while compiling lablgl.1.07 ========================================#
    # context              2.2.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.4.14.1 | file:///home/opam/opam-repository
    # path                 ~/.opam/4.14/.opam-switch/build/lablgl.1.07
    # command              ~/.opam/opam-init/hooks/sandbox.sh build make INSTALLDIR=/home/opam/.opam/4.14/lib/lablgl glut
    # exit-code            2
    # env-file             ~/.opam/log/lablgl-7-dde7f3.env
    # output-file          ~/.opam/log/lablgl-7-dde7f3.out
    ### output ###
    # cd src && make all LIBDIR="`ocamlc -where`"
    # make[1]: Entering directory '/home/opam/.opam/4.14/.opam-switch/build/lablgl.1.07/src'
    # camlp5o pr_o.cmo -impl var2def.ml4 -o var2def.ml
    # make[1]: camlp5o: No such file or directory
    # make[1]: *** [../Makefile.common:64: var2def.ml] Error 127
    # make[1]: Leaving directory '/home/opam/.opam/4.14/.opam-switch/build/lablgl.1.07/src'
    # make: *** [Makefile:12: lib] Error 2
@emillon emillon mentioned this pull request Jun 28, 2023
6 tasks
@emillon
Copy link
Contributor Author

emillon commented Jun 28, 2023

I'm not 100% sure about the fix, but depending on camlp5 for camlp5o seems good

@mseri
Copy link
Member

mseri commented Jun 28, 2023

For this one I'll wait for the CI

@mseri
Copy link
Member

mseri commented Jun 28, 2023

A number of builds went through fine. Thanks!

@mseri mseri merged commit f35584e into ocaml:master Jun 28, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants