[new release] argon2 (1.0.2)

[Khady]

OCaml bindings to Argon2

• Project page: https://github.com/Khady/ocaml-argon2
• Documentation: https://khady.github.io/ocaml-argon2/

[samoht]

this seems to be missing a depext?

[MarcCoquand]

Hi! Any way we can help out to get this merge? It resolves not only the issue with argon2 not working on OS X but also with Nix

[Khady]

I’ve added the depexts for the systems I know about

[mseri]

There seems to be linking issues though:

#=== ERROR while compiling FPauth-strategies.1.0.0 ============================#
# context              2.2.0~alpha4~dev | linux/x86_64 | ocaml-base-compiler.4.14.1 | file:///home/opam/opam-repository
# path                 ~/.opam/4.14/.opam-switch/build/FPauth-strategies.1.0.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune runtest -p FPauth-strategies -j 255
# exit-code            1
# env-file             ~/.opam/log/FPauth-strategies-7-dd1073.env
# output-file          ~/.opam/log/FPauth-strategies-7-dd1073.out
### output ###
# File "test/strategies/dune", line 2, characters 7-11:
# 2 |  (name unit)
#            ^^^^
# (cd _build/default/test/strategies && ./unit.exe)
# Fatal error: exception Dl.DL_error("./unit.exe: undefined symbol: argon2_type2string")
# Raised at Dl._report_dl_error in file "src/ctypes-foreign/dl.ml.unix", line 44, characters 20-44
# Called from Ctypes_foreign_basis.Make.foreign in file "src/ctypes-foreign/ctypes_foreign_basis.ml", line 47, characters 19-47
# Re-raised at Ctypes_foreign_basis.Make.foreign in file "src/ctypes-foreign/ctypes_foreign_basis.ml", line 49, characters 50-59
# Called from Argon2.Kind.argon2_type2string in file "src/argon2.ml", line 18, characters 4-98

[samoht]

@Khady could you have a look at the linking issue?

# Fatal error: exception Dl.DL_error("./unit.exe: undefined symbol: argon2_type2string")

Is this expected?

[samoht]

I'm merging the PR anyway as it seems to fix user issues (from @MarcCoquand report). But feel free to investigate why one reverse dependency is broken :-)

[Khady]

the linking issue is not expected. It is being tracked in Khady/ocaml-argon2#13

[hannesm]

may the linking issue be related / identical to https://discuss.ocaml.org/t/how-to-properly-define-a-library-with-c-bindings/14419/5 ? (I've no clue, and am not sure whether argon uses ctypes)