Package libbinaryen.113.0.0 #24519
Merged
Package libbinaryen.113.0.0 #24519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mseri
reviewed
Sep 25, 2023
| "conf-cmake" {build} | ||
| "dune" {>= "3.0.0"} | ||
| "dune-configurator" {>= "3.0.0"} | ||
| "js_of_ocaml-compiler" {with-test & >= "4.1.0" & < "6.0.0"} |
There was a problem hiding this comment.
Is version 6 known to break the tests?
There was a problem hiding this comment.
v6 hasn't been released yet. Jsoo major versions are known to break this package: v5 had various bugs and an OoM with libbinaryen that wasn't fixed for several versions.
|
@mseri is this good? I'd like to land the bindings, but they require this to be published |
|
Sure, sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libbinaryen.113.0.0Libbinaryen packaged for OCaml
113.0.0 (2023-09-14)
⚠ BREAKING CHANGES
Features
🐫 Pull-request generated by opam-publish v2.0.3