Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FreeBSD conf-rdkit support #24708

Merged
merged 9 commits into from
Oct 30, 2023
Merged

Add FreeBSD conf-rdkit support #24708

merged 9 commits into from
Oct 30, 2023

Conversation

jmid
Copy link
Contributor

@jmid jmid commented Oct 27, 2023

This PR adds conf-rdkit support for FreeBSD.

I'm unsure of the right include dir and compile flags on FreeBSD and so mimic the Linux ones for a start.

@jmid jmid mentioned this pull request Oct 27, 2023
Merged
@jmid jmid marked this pull request as draft October 27, 2023 23:22
@jmid
Copy link
Contributor Author

jmid commented Oct 29, 2023

After a bit of trial and error, a combination of 2 include paths make things work on FreeBSD.
e493083 and c5e704c adds acceptable CI failure versions for Alpine and Oracle.
Finally 630ee40 attempt the extra include dir on macOS which is currently failing.

@jmid
Copy link
Contributor Author

jmid commented Oct 29, 2023

Cleaned up the history a bit after realizing that include dirs won't change anything on macOS unless some depext is listed.
I then marked the tested Fedora and OpenSuse version as acceptable CI failures too.

The remaining failures are:

@jmid
Copy link
Contributor Author

jmid commented Oct 29, 2023

The latest commit also marks fedora-38 an acceptable CI failure.
Despite these annotations the Fedora runs are still marked as failures.
I suspect that this is because the system package installation fails (pkg not available on these newer Fedoras).

@jmid jmid marked this pull request as ready for review October 29, 2023 23:07
@jmid
Copy link
Contributor Author

jmid commented Oct 30, 2023

The above summary should still be accurate.

For context, #24633 explains that the modern way to install rdkit is through pip for which the following opam issue has been opened: ocaml/opam#5703

Adding FreeBSD support and adding a few x-ci-accept-failures is a low-effort approach to get a few more CI green lights until the above is supported.

@mseri
Copy link
Member

mseri commented Oct 30, 2023

This is a strict improvement over what we had. Thanks!

@mseri mseri merged commit c6de228 into ocaml:master Oct 30, 2023
1 of 2 checks passed
@jmid jmid deleted the conf-rdkit-freebsd branch October 30, 2023 22:47
nberth pushed a commit to nberth/opam-repository that referenced this pull request Jun 18, 2024
@jmid @nberth
Add FreeBSD conf-rdkit support (ocaml#24708)
f6bdd6c 
* Add FreeBSD rdkit support

* Follow the macOS route for FreeBSD

* Change include directory for FreeBSD

* Add an rdkit include flag for FreeBSD

* Mark oraclelinux-9 as an acceptable CI failure too

* Mark alpine-3.18 as an acceptable CI failure too

* Mark fedora-37 as an acceptable CI failure too

* Mark opensuse-15.5 as an acceptable CI failure too

* Mark fedora-38 as an acceptable CI failure too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannesm hannesm hannesm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmid @mseri @hannesm