Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark let-if and ssh-agent-unix unavailable #24961

Merged
merged 1 commit into from Dec 28, 2023

Conversation

reynir
Copy link
Contributor

@reynir reynir commented Dec 19, 2023

let-if was a fun experiment, but I don't think it's seen any usage and I now think it shouldn't be used.

ssh-agent-unix was not meant to be published, but was published sort of by accident due to dune-release picking it up. Previous versions have been of poor quality, and I don't think it's very useful beyond small examples. I would also like to not have to maintain this package (still want to maintain ssh-agent though!)

See also the discussion in #23789 (comment)

@mseri
Copy link
Member

mseri commented Dec 19, 2023

I am letting this wait a moment to see if there are users.
There are surely no published packages using them

❯ opam list --depends-on=ssh-agent-unix --all
# Packages matching: depends-on(ssh-agent-unix) & any
# No matches found
❯ opam list --depends-on=let-if --all
# Packages matching: depends-on(let-if) & any
# No matches found

@mseri
Copy link
Member

mseri commented Dec 28, 2023

No complain here, I am going on with it

@mseri mseri merged commit f40aa30 into ocaml:master Dec 28, 2023
1 check failed
@reynir reynir deleted the let-if-ssh-agent-unix-unavailable branch January 3, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants