New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new release] ppx_deriving_yaml (0.2.2) #25040
[new release] ppx_deriving_yaml (0.2.2) #25040
Conversation
CHANGES: - Embed errors in the AST (patricoferris/ppx_deriving_yaml#51, @patricoferris and special thanks to @panglesd for the detailed issue in patricoferris/ppx_deriving_yaml#48)
Are the test failures on bytecode-only compilers expected? |
Hmm thanks for the info @mseri -- I didn't realise that's what distinguished those compilers. I tried locally with something like:
And then trying to install and run the tests, but can't make cmdliner happy for some reason. Just posting here in case this has come up before maybe ?
|
Blergh! Nevermind, a rogue |
Hmm yeh this reproduces the problem -- something up with bytecode only toplevels getting ppxes. You see it just using |
"ocaml" {>= "4.08.1"} | ||
"ppxlib" {>= "0.25.0"} | ||
"odoc" {with-doc} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
] | |
] | |
conflicts: [ | |
"ocaml-option-bytecode-only" | |
] |
For the moment we could solve it this way and release. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if it is only the MDX based tests that are failing, I wonder if I can do some dune magic to disable them if it detects byte code. Thanks for the help so far, I'll get back to you shortly :))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yaml PPX Deriver
CHANGES:
for the detailed issue in Embed errors in the AST instead of raising patricoferris/ppx_deriving_yaml#48)