Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: zipc.0.2.0 #25105

Merged
merged 1 commit into from Jan 24, 2024
Merged

Add: zipc.0.2.0 #25105

merged 1 commit into from Jan 24, 2024

Conversation

dbuenzli
Copy link
Collaborator

  • Add: zipc.0.2.0 home, doc, issues
    ZIP archive and deflate codec for OCaml

zipc v0.2.0 2024-01-22 La Forclaz (VS)

  • Decompression limits in Zipc_deflate (breaking change). When the
    decompression_size argument of decompression functions is
    specified, decompression errors as soon as the decompressed size
    exceeds that value. Previously it was only treated as a hint.

  • Zipc.File.to_binary_string, error if the decompression size starts
    exceeding File.decompressed_size rather than ignoring this value.
    This allows clients to enforce limits on the decompression of
    untrusted zip file. Thanks to Valentin Gatien-Baron for suggesting (#1).

  • Zipc.File.make: fix default value of version_needed_to_extract. It
    was the same as version_made_by which is wrong. Now defaults
    to 20(PKZip 2.0). Thanks to Valentin Gatien-Baron for the report (#3).

  • Fix encoding of Zipc.File.gp_flags. Bit 3 indicates presence of a
    data descriptor. Since we never write one, we clear the bit on
    encoding. Not doing this would result in interoperability issues
    when rewriting archives that originally had data descriptors. Thanks
    to Valentin Gatien-Baron for tracking this down (#4).

  • Fix swapped date and time in the encoding of local file headers.
    Thanks to Valentin Gatien-Baron for the fix (#5).

  • Write entries in the central directory in the same order as files
    are written in the archive. In particular this gives less
    surprising result on unzip -l. Thanks to Valentin Gatien-Baron
    for the patch (#2).


Use b0 -- .opam publish zipc.0.2.0 to update the pull request.

@dbuenzli
Copy link
Collaborator Author

/cc @v-gb

@raphael-proust
Copy link
Collaborator

Looks ok to me.

FWIW, the tests are not running in the opam-repo CI (unless I missed something?) because there's no command for it in the opam file.

@dbuenzli
Copy link
Collaborator Author

I don't know but none of my packages ever had something in the test: field.

@mseri mseri merged commit fc0c2fd into ocaml:master Jan 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants