-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new-release] ppx_deriving_yojson 3.8.0 #25720
[new-release] ppx_deriving_yojson 3.8.0 #25720
Conversation
I'm creating this as a draft first to get the result of the revdep builds. |
d34f67d
to
1466509
Compare
I'm going through the errors here:
Other failures ( |
92ab036
to
7edd888
Compare
I've looked into I'll simply add an upper bound here as if a fix is needed, it's either on |
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
This will prevent build breakage following a fix in ppx_deriving_yojson that now makes it properly report errors when `[@@deriving yojson]` is used on nodes it does not support, such as exception declaration. Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
7edd888
to
a941a7b
Compare
|
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
pa_ppx_q_ast requires a lower bound on pa_ppx, from which it takes pcre2 transitively. I will send a fix separately. Thanks |
Changes