Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new release] styled-ppx (0.57.0) #26159

Closed
wants to merge 1 commit into from
Closed

[new release] styled-ppx (0.57.0) #26159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions packages/styled-ppx/styled-ppx.0.57.0/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
opam-version: "2.0"
synopsis: "Type-safe styled components for ReScript and Melange"
description:
"styled-ppx is the ppx that brings styled components to ReScript and Melange, allowing you to create React Components with type-safe style definitions using CSS."
maintainer: ["David Sancho <dsnxmoreno@gmail.com>"]
authors: ["David Sancho <dsnxmoreno@gmail.com>"]
license: "MIT"
homepage: "https://styled-ppx.vercel.app"
bug-reports: "https://github.com/davesnx/styled-ppx/issues"
depends: [
"dune" {>= "3.8"}
"ocaml" {>= "5.1.0"}
"reason" {>= "3.11.0"}
"menhir" {>= "20220210"}
"ppx_deriving" {>= "5.0"}
"ppx_deriving_yojson" {>= "3.7.0"}
"ppxlib" {>= "0.27.0"}
"sedlex" {>= "3.2"}
"melange" {>= "3.0.0"}
"server-reason-react"
"reason-react" {>= "0.14.0"}
"alcotest" {with-test}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"alcotest" {with-test}
"alcotest"

this is currently not just a test dependency, is it expected?

#=== ERROR while compiling styled-ppx.0.57.0 ==================================#
# context              2.2.0~rc1 | linux/x86_64 | ocaml-base-compiler.5.2.0 | pinned(https://github.com/davesnx/styled-ppx/releases/download/0.57.0/styled-ppx-0.57.0.tbz)
# path                 ~/.opam/5.2/.opam-switch/build/styled-ppx.0.57.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p styled-ppx -j 31 @install
# exit-code            1
# env-file             ~/.opam/log/styled-ppx-7-bd5418.env
# output-file          ~/.opam/log/styled-ppx-7-bd5418.out
### output ###
# File "packages/alcotest-extra/dune", line 4, characters 12-20:
# 4 |  (libraries alcotest))
#                 ^^^^^^^^
# Error: Library "alcotest" not found.
# -> required by library "styled-ppx.alcotest-extra" in
#    _build/default/packages/alcotest-extra
# -> required by _build/default/META.styled-ppx
# -> required by _build/install/default/lib/styled-ppx/META
# -> required by _build/default/styled-ppx.install
# -> required by alias install

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh shit, I made a library depending on alcotest but didn't plan to make it "public". Let me push a new version with a fix for this.

"conf-npm" {with-test}
"reason-react-ppx" {with-dev-setup}
"ocaml-lsp-server" {with-dev-setup}
"ocamlformat" {with-dev-setup}
"utop" {with-dev-setup}
"odoc" {with-doc}
]
build: [
["dune" "subst"] {dev}
[
"dune"
"build"
"-p"
name
"-j"
jobs
"@install"
"@runtest" {with-test}
"@doc" {with-doc}
]
]
dev-repo: "git+https://github.com/davesnx/styled-ppx.git"
depexts: [
["@emotion/css"] {npm-version = ">=11.0.0"}
]
url {
src:
"https://github.com/davesnx/styled-ppx/releases/download/0.57.0/styled-ppx-0.57.0.tbz"
checksum: [
"sha256=9db556084c15bc1a9c96fb2a4ce2ae5cf9c05732ebebe6a82cead05a10d5fcaa"
"sha512=853c7989b34b30cb8711256f372c6c2d721dfc9dec73ace6aa6f74c4c555b719c5ecb1f5ed665050895f8ac997ba92d315db819b51c5e3e462f59c25a81b2ad4"
]
}
x-commit-hash: "4b80cb6bf390d32a5c95bce56407b9cf558746bd"
Loading