-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mariadb: add missing deps and depexts #7352
Conversation
✅ All lint checks passed 5358c6d
|
There's still some kind of
|
I found another one, but I still seem to be missing some, and I don't have the tools to debug this completely. The OSX one is correct, AFAICT. |
@andrenth, do you know which system packages are needed? |
@@ -15,5 +15,12 @@ depends: [ | |||
"ocamlfind" {build} | |||
"ctypes" {>= "0.7.0"} | |||
"ctypes-foreign" {>= "0.4.0"} | |||
"async" | |||
"lwt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It requires both??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It builds its example files, which include both Async examples and Lwt examples.
Some of these depext questions were answered in the original #7222. |
I don't think the library should require either lwt or async, since they're not really dependencies. People interested in building The examples can clone the fit repository. The libmariadbclient-dev packages in Debian and Ubuntu don't support the nonblocking calls, which is why I didn't add the depexts. You need to install the packages from mariadb.org. |
Then we should change the build instructions because calling just |
Hmm weird, both flags in the _oasis file default to false... |
I've reorganized the examples structure to avoid this problem and released version 0.5.1 (#7408). |
Note: the travis failures are due to #7391. I've restarted the builds. |
I think the remaining problem is a depext version problem, and the example/dependency issue is resolved in 0.5.1, so I'm merging this. |
No description provided.