Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mariadb: add missing deps and depexts #7352

Merged
merged 2 commits into from
Sep 30, 2016

Conversation

damiendoligez
Copy link
Member

No description provided.

@camelus
Copy link
Contributor

camelus commented Sep 5, 2016

✅ All lint checks passed 5358c6d
  • These packages passed lint tests: mariadb.0.5.0

@yallop
Copy link
Member

yallop commented Sep 9, 2016

There's still some kind of depext/linking problem:

# /usr/bin/ld: cannot find -lmysqlclient

@damiendoligez
Copy link
Member Author

I found another one, but I still seem to be missing some, and I don't have the tools to debug this completely.

The OSX one is correct, AFAICT.

@yallop
Copy link
Member

yallop commented Sep 9, 2016

@andrenth, do you know which system packages are needed?

@@ -15,5 +15,12 @@ depends: [
"ocamlfind" {build}
"ctypes" {>= "0.7.0"}
"ctypes-foreign" {>= "0.4.0"}
"async"
"lwt"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires both??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It builds its example files, which include both Async examples and Lwt examples.

@dsheets
Copy link
Member

dsheets commented Sep 9, 2016

Some of these depext questions were answered in the original #7222.

@andrenth
Copy link
Contributor

andrenth commented Sep 9, 2016

I don't think the library should require either lwt or async, since they're not really dependencies. People interested in building The examples can clone the fit repository.

The libmariadbclient-dev packages in Debian and Ubuntu don't support the nonblocking calls, which is why I didn't add the depexts. You need to install the packages from mariadb.org.

@damiendoligez
Copy link
Member Author

I don't think the library should require either lwt or async, since they're not really dependencies. People interested in building The examples can clone the fit repository.

Then we should change the build instructions because calling just make will attempt to build the examples.

@andrenth
Copy link
Contributor

andrenth commented Sep 9, 2016

Hmm weird, both flags in the _oasis file default to false...

@andrenth
Copy link
Contributor

I've reorganized the examples structure to avoid this problem and released version 0.5.1 (#7408).

@damiendoligez
Copy link
Member Author

Note: the travis failures are due to #7391. I've restarted the builds.

@yallop
Copy link
Member

yallop commented Sep 30, 2016

I think the remaining problem is a depext version problem, and the example/dependency issue is resolved in 0.5.1, so I'm merging this.

@yallop yallop merged commit ed299a3 into ocaml:master Sep 30, 2016
@damiendoligez damiendoligez deleted the mariadb-add-deps branch September 30, 2016 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants