Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+flow_parser.0.40.0 #8541

Merged
merged 2 commits into from Mar 17, 2017
Merged

+flow_parser.0.40.0 #8541

merged 2 commits into from Mar 17, 2017

Conversation

gabelevi
Copy link
Contributor

No description provided.

@camelus
Copy link
Contributor

camelus commented Feb 24, 2017 •
edited

❗ opam-lint warnings 0536135

  • flow_parser.0.40.0 has some warnings:

    • warning 26: No field 'install', but a field 'remove': install instructions probably part of 'build'. Use the 'install' field or a .install file
✅ Installability check (6275 → 6276)
  • new installable packages (1): flow_parser.0.40.0

avsm
avsm reviewed Feb 26, 2017
View reviewed changes
packages/flow_parser/flow_parser.0.40.0/opam Outdated
build: [ "sh" "-c" "cd src/parser && make ocamlfind-install" ]

remove: ["ocamlfind" "remove" "flow_parser"]
depends: "ocamlfind" {build}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this require a ocamlbuild dependency as well, as per #8550 ?

gasche
gasche suggested changes Mar 13, 2017
View reviewed changes
Copy link
Member

@gasche gasche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabelevi, could you add the ocamlbuild dependency? Otherwise build will break in an empty environment and make our QA more difficult.

@gasche gasche merged commit 053b7a3 into ocaml:master Mar 17, 2017
@gasche
Copy link
Member

gasche commented Mar 17, 2017

@gabelevi thanks, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avsm avsm avsm left review comments

@gasche gasche gasche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gabelevi @camelus @gasche @avsm