Merge pull request #5560 from rjbou/security

Reftests: add tests to check url handling behaviours
ocaml · Aug 29, 2023 · cfa447c · cfa447c
2 parents 8a23fc0 + f8ffbbe
commit cfa447c
Show file tree

Hide file tree

Showing 8 changed files with 3,081 additions and 392 deletions.
diff --git a/.github/workflows/ci.ml b/.github/workflows/ci.ml
@@ -369,6 +369,7 @@ let main_test_job ~analyse_job ~build_linux_job ~build_windows_job:_ ~build_macO
   let host = host_of_platform platform in
   let ocamlv = "${{ matrix.ocamlv }}" in
   job ~oc ~workflow ?section ~runs_on:(Runner [runner]) ~env:[("OPAM_TEST", "1")] ~matrix ~needs ("Test-" ^ name_of_platform platform)
+    ++ only_on MacOS (install_sys_packages ["coreutils"] ~descr:"Install gnu coreutils" [MacOS])
     ++ checkout ()
     ++ only_on Linux (run "Install bubblewrap" ["sudo apt install bubblewrap"])
     ++ cache Archives

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -325,6 +325,8 @@ jobs:
     env:
       OPAM_TEST: 1
     steps:
+    - name: Install gnu coreutils
+      run: brew install coreutils
     - name: Checkout tree
       uses: actions/checkout@v3
     - name: src_ext/archives and opam-repository Cache

diff --git a/master_changes.md b/master_changes.md
@@ -102,10 +102,13 @@ users)
 ## Reftests
 ### Tests
   * Lint: add test for W53, to test extra file with good hash [#5639 @rjbou]
+  * Add several checksum & cache validation checks for archive, extra-source section, and extra-file field [#5560 @rjbou]
+  * Move local-cache into archive-field-checks test [#5560 @rjbou]
 
 ### Engine
 
 ## Github Actions
+  * Add coreutils install for cheksum validation tests [#5560 @rjbou]
 
 ## Doc