Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite rsync loop when pinning a package inside OPAMROOT #2032

Closed
samoht opened this issue Feb 26, 2015 · 1 comment
Closed

Infinite rsync loop when pinning a package inside OPAMROOT #2032

samoht opened this issue Feb 26, 2015 · 1 comment
Labels
KIND: BUG
Milestone
1.2.1

Comments

@samoht
Copy link
Member

samoht commented Feb 26, 2015

This happens when you try to have a local OPAMROOT per project. See https://travis-ci.org/avsm/opam-boot/jobs/52260430

In that run, OPAMROOT = PIN_DIRECTORY so opam tries to rsync .opam/ into .opam/.../build which obviously fails.

A possible fix for this: add OPAMROOT to the list of exclude files, add a way to add new files to excludes to the opam rsync command, automatically detect cycles and add the right things to the exclude path, ...

A possible workaround: pin using -k git or -k mixed.
@dsheets
Copy link
Member

dsheets commented Feb 26, 2015

Similar to #1956.

@AltGr AltGr added this to the 1.2.1 milestone Feb 27, 2015
AltGr added a commit to OCamlPro/opam that referenced this issue Feb 27, 2015
@AltGr
Some safeguard agains rsync'ing sub-directories
a220523 
may not reliably detect symlinking loops, but should avoid most crazyness

Closes ocaml#1956, ocaml#2032
@AltGr AltGr closed this as completed Feb 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
KIND: BUG
Projects
None yet
Milestone
1.2.1
Development

No branches or pull requests
3 participants
@dsheets @samoht @AltGr