Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch translation is brittle w.r.t. locales #4407

Open
AltGr opened this issue Oct 28, 2020 · 0 comments
Open

Patch translation is brittle w.r.t. locales #4407

AltGr opened this issue Oct 28, 2020 · 0 comments
Assignees
@dra27
Labels
KIND: BUG
Projects
Opam 2.3

Comments

@AltGr
Copy link
Member

AltGr commented Oct 28, 2020

With LC_ALL=fr_FR.UTF-8, I can get stuff such as:

@@ -1 +1 @@
-Original line
\ Pas de fin de ligne à la fin du fichier

instead of the handled No newline at end of file
I'll force the locales for the tests/patcher test for the time being, but this might need proper handling.
See

opam/src/core/opamSystem.ml

Line 1363 in 4141b47

if line = "\\ No newline at end of file" then

AltGr added a commit to OCamlPro/opam that referenced this issue Oct 28, 2020
@AltGr
Patcher test: fix locale
a48e628 
ref. ocaml#4407
rjbou pushed a commit to OCamlPro/opam that referenced this issue Dec 3, 2020
@AltGr @rjbou
Patcher test: fix locale
80ff7fe 
ref. ocaml#4407
rjbou pushed a commit to rjbou/opam that referenced this issue Dec 8, 2020
@AltGr @rjbou
Patcher test: fix locale
dec3545 
ref. ocaml#4407
rjbou pushed a commit to rjbou/opam that referenced this issue Dec 8, 2020
@AltGr @rjbou
Patcher test: fix locale
4835e40 
ref. ocaml#4407
rjbou pushed a commit to rjbou/opam that referenced this issue Dec 8, 2020
@AltGr @rjbou
Patcher test: fix locale
cf9235e 
ref. ocaml#4407
rjbou pushed a commit to rjbou/opam that referenced this issue Dec 9, 2020
@AltGr @rjbou
Patcher test: fix locale
94ea36c 
ref. ocaml#4407
rjbou pushed a commit to rjbou/opam that referenced this issue Dec 9, 2020
@AltGr @rjbou
Patcher test: fix locale
0f22810 
ref. ocaml#4407
rjbou pushed a commit to rjbou/opam that referenced this issue Dec 9, 2020
@AltGr @rjbou
Patcher test: fix locale
dbd6c3a 
ref. ocaml#4407
rjbou pushed a commit to rjbou/opam that referenced this issue Dec 9, 2020
@AltGr @rjbou
Patcher test: fix locale
e75b46d 
ref. ocaml#4407
rjbou pushed a commit to rjbou/opam that referenced this issue Dec 9, 2020
@AltGr @rjbou
Patcher test: fix locale
faa8c0d 
ref. ocaml#4407
rjbou pushed a commit to rjbou/opam that referenced this issue Dec 9, 2020
@AltGr @rjbou
Patcher test: fix locale
5a23d7c 
ref. ocaml#4407
AltGr added a commit to AltGr/opam that referenced this issue Dec 16, 2020
@AltGr
Patcher test: fix locale
9c7922e 
ref. ocaml#4407
@dra27 dra27 self-assigned this Jul 8, 2021
@dra27 dra27 added the KIND: BUG label Jul 8, 2021
@dra27 dra27 added this to To do in Opam 2.2.0 via automation Jul 8, 2021
@dra27 dra27 added this to the 2.2.0~alpha milestone Jul 8, 2021
@dra27 dra27 moved this from To do to Bump to 2.3? in Opam 2.2.0 Jan 13, 2022
@dra27 dra27 removed this from Bump to 2.3? in Opam 2.2.0 May 17, 2022
@dra27 dra27 added this to To do in Opam 2.3 via automation May 17, 2022
@dra27 dra27 removed this from the 2.2.0~alpha milestone Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dra27 dra27

Labels
KIND: BUG
Projects
Opam 2.3
  
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AltGr @dra27