Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling make lib-ext should not be permitted without calling the configure script first #4772

Closed
kit-ty-kate opened this issue Jul 28, 2021 · 0 comments · Fixed by #4776
Closed

Calling make lib-ext should not be permitted without calling the configure script first #4772

kit-ty-kate opened this issue Jul 28, 2021 · 0 comments · Fixed by #4776
Labels
AREA: BUILD
Projects
Opam 2.2.0

Comments

@kit-ty-kate
Copy link
Member

On macOS and FreeBSD, if you call make lib-ext without calling ./configure before the command will crash because md5sum does not exist. See #4761.

I think this should not be made possible and the makefile should fail with a message telling the user to call the configure script first unless the cold target was given.
@dra27 dra27 linked a pull request Jul 29, 2021 that will close this issue
Replace make lib-ext with a configure-based check #4776
Merged
@dra27 dra27 added this to To do in Opam 2.2.0 via automation Jul 29, 2021
@dra27 dra27 moved this from To do to In progress in Opam 2.2.0 Jul 29, 2021
Opam 2.2.0 automation moved this from In progress to Done Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
AREA: BUILD
Projects
Opam 2.2.0
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace make lib-ext with a configure-based check dra27/opam
1 participant
@kit-ty-kate