Replace make lib-ext with a configure-based check
#4776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 29, 2021
Closed
opam has always automatically built Dune if it was missing (even without `make lib-ext`). This option adds support to force that by passing `--without-dune` to configure, instructing `configure` to ignore any dune binary in PATH. `--with-dune` allows the opposite, forcing dune to be in PATH. As a small debugging trick, `--with-dune=foo` allows `foo` to be used in place of `dune`.
Related to an unreleased patch being backported to seq 0.1 and should have been removed when seq 0.2 was adopted.
make lib-ext is an artefact of OPAM 1.2.2's build system, when it actually did something. Since the switch to Jbuilder and then Dune, all it does is set-up a source tree which is more appropriately done from configure, whose job that is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lib-extis an artefact from the pre-Jbuilder days when it actually built .cma and .cmxa archives to be put into a separatelibdirectory. The workflow has never made sense since the switch to using jbuilder/dune vendored libraries for this.This PR is on buy one, get two free:
--without-duneis added toconfigureto allow disabling or forcing the use ofdunefromPATH. This is related. Default behaviour is unchanged: if you don't specify anything, Dune will be automatically built if it's missing.--with-vendored-depsnow replacesmake lib-ext. By default, this gets enabled whenever the oldlib-extmessage would have been disabled. At the end ofconfigure, sources are downloaded and extracted as required. It's all the same mechanism, it's only invocation which has altered, so full tarballs would use their local copies in the "download" phase, etc.