Workaround incorrect <limits.h> in musl in the release scripts
#5383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dra27
force-pushed
the
fix-ngroups_max
branch
from
d6e13c8
to
50341bd
Compare
5 tasks
musl ships with an incorrect value for NGROUPS_MAX in limits.h. This affects OCaml's Unix.getgroups function. Fortunately, for the opam binary, this can be worked around simply by ensuring /usr/include/limits.h has been patched before OCaml is compiled. This would not work for Unix.initgroups, but fortunately opam doesn't need that.
Allows the release scripts on master to build opam 2.1 release tags.
kit-ty-kate
force-pushed
the
fix-ngroups_max
branch
from
50341bd
to
b6dc7de
Compare
kit-ty-kate
approved these changes
Nov 14, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate for #5373 - musl has a pre-kernel 2.6.4 value of
32forNGROUPS_MAX. This PR simply patches thelimits.hto correct that (in the Docker builds only!) so that OCaml is compiled with the 2.6.4+ value of 65536.In passing, a slightly inelegant (but tested!) hack to add
-lsha_stubsonly when needed (so thatmake -C release TAG=2.1.3 x86_64-linuxworks with master)