Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint check use of package variables in depends/depopts/conflicts/depexts #5951

Open
kit-ty-kate opened this issue May 13, 2024 · 2 comments
Open

Comments

@kit-ty-kate
Copy link
Member

Currently package variables are not allowed in the depends, depopts, conflicts or depexts field (see #5455 for the latter). However opam doesn't warn of their uses in these fields which confuses users (see ocaml/opam-repository#25863)

It would be nice to have them trigger a warning during linting.
It would be nice to also mention this in the documentation in the section on package variables. As far as i know, the only mention of it in the documentation is in the description of the depends field

@kit-ty-kate
Copy link
Member Author

As noted by @rjbou, W29 does that already but only misses depexts

@lukstafi
Copy link
Contributor

Note that it is not unreasonable to think that depexts might have more lenient restrictions than depends, since they cannot depend on opam packages or have exclusion conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants