Depext filter enhancement: resolve package variables #5455
Conversation
rjbou
added
PR: QUEUED
In order to be able to resolve undefined variables at several stages (once switch_state loaded, on install, etc.)
They are lately used for resolving at install stage, for availability checkup, etc. permitting to evaluate on filter install status of a package or its version.
kit-ty-kate
force-pushed
the
depext-filter
branch
from
001da67
to
a312e7e
Compare
kit-ty-kate
removed
the
PR: QUEUED
| ### OPAMVAR_os_family=dummy-success::0 opam install conf-os --show | ||
| The following actions would be performed: | ||
| === install 2 packages | ||
| - install conf-os 1 | ||
| - install conf-os1 1 [required by conf-os] | ||
| [WARNING] These additional system packages are required, but not available on your system: os1-depext |
There was a problem hiding this comment.
I'm not sure to understand this test result. Why is this just a warning if the system package isn't available?
There was a problem hiding this comment.
It should be a simple message indeed, or an error, not a warning.
There was a problem hiding this comment.
In fact, here it's with --show, it errors at install step.
| ### OPAMVAR_os_family=dummy-success::0 opam install conf-os | ||
| The following actions will be performed: | ||
| === install 2 packages | ||
| - install conf-os 1 | ||
| - install conf-os1 1 [required by conf-os] | ||
| [WARNING] These additional system packages are required, but not available on your system: os1-depext | ||
| [ERROR] Some packages have missing dependencies after resolution: |
There was a problem hiding this comment.
Same sort of question than above here: why are we displaying the error so late?
There was a problem hiding this comment.
We check depext availability when we try to install once we have the solution. We resolve last filters (here conf-os1:installed) with an environment that contains packages to install as installed.
| - install conf-os1 1 [required by conf-os] | ||
| [WARNING] These additional system packages are required, but not available on your system: os1-depext | ||
| [ERROR] Some packages have missing dependencies after resolution: | ||
| - conf-os.1: os1-depext |
There was a problem hiding this comment.
Shouldn't also say something about os2-depext ?
There was a problem hiding this comment.
As we resolve with the solution, conf-os1:installed resolves to true while conf-os2 resolves to false, that's why we display only os1-depext.
We can recheck availability at this stage, and print a message for os2-depext.
|
I'm rather unconvinced by the solution and I'm still confused as to why this is necessary for Windows support.
Could describe what the problem it's trying to solve is? |
kit-ty-kate
moved this from PR to review for 2.2.0~alpha
to PR to update for 2.2.0~alpha
in Opam 2.2.0
kit-ty-kate
added
PR: WIP
rjbou
moved this from PR to update for 2.2.0~alpha
to After ~alpha; before release
in Opam 2.2.0
depexts:filter can now handle package variables. They are stored and resolved on the go & gradually. On install, packages appearing in solution are considered as installed for resolving. Seedepexts.testfor examples.