Semi-synchronous verbose mode #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As soon as there is just one sub-process running, in verbose mode, show its output every second. Closes ocaml#1913 This uses a SIGALRM to stop the wait at regular intervals -- disabled on Windows.
|
Not sure it's really simpler and more portable than |
|
Well it has several merits, mainly, we retain control of all output from OCaml code in OPAM. For example, it's possible to start printing the output synchronously as soon as there is a single process left running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As soon as there is just one sub-process running, in verbose mode, show its
output every second.
Closes #1913 This uses a SIGALRM to stop the wait at regular intervals --
disabled on Windows.