opam config exec now does not set OPAMSWITCH unless --switch or OPAMSWITCH #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WITCH Previously, opam config exec would always set the OPAMSWITCH environment variable. This causes issues when running processes like shells with `opam config exec -- bash` or similar because the shell's environment is not precisely the same as the parent process's environment. In partiular, the absence of OPAMSWITCH was not preserved and therefore the use of interactive opam commands was more unwieldy.
|
Great, thanks! |
AltGr
added a commit
that referenced
this pull request
Feb 24, 2016
opam config exec now does not set OPAMSWITCH unless --switch or OPAMSWITCH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
opam config execwould always set theOPAMSWITCHenvironment variable. This causes issues when running processes like shells withopam config exec -- bashor similar because the shell's environment is not precisely the same as the parent process's environment. In partiular, the absence ofOPAMSWITCHwas not preserved and therefore the use of interactive opam commands was more unwieldy.Using
opam config execto spawn a shell is a common technique when scripting with opam in order to avoid needing to run a separate command to set up the environment in a subshell. See http://lists.ocaml.org/pipermail/opam-devel/2016-February/001393.html.