next: add package subcommand #2551
Conversation
locate_ancestor will find the ancestor of the provided directory for which the predicate returns true.
Allow users to call build_package on a directory containing a package that is ready to be built. It seems as if the the function should really perform the functionality exposed through the `In_place variant, delegating the work for extracting the package to the caller. It is left like this to minimize the change necessary for the implementation of the local sandbox feature.
(cherry picked from commit 58d589f)
| in | ||
| (* XXX(seliopou): This whole dance is necessary because | ||
| * OpamAction.build_package reads global state, rather than explicitly taking | ||
| * the build_test and build_doc arguments *) |
There was a problem hiding this comment.
Indeed. It would be best to add them as arguments troughout. Meanwhile, it may be more consistent to remove the argument here and relying on the options being set in OpamMain.
Note that since we would like to be able to set these options for specific packages (#2506), this will need to be changed anyway at that point.
|
Thanks a lot! This is great and many are looking forward to this feature. I think you could go further though: I would expect For that you would need to rely on Some more design questions:
|
|
Ah, also, this still seems to target the |
The package subcommand is meant to work in any directory that contains a valid package, not just in local sandboxes. As far as I can recall, the only thing that tied the package subcommand to a local sandbox was this error message.
|
Tentative initial doc. Feedback welcome: https://gist.github.com/samoht/2188fbd01b1d40a3e2063f3a270bf8fd |
|
Superseded by |
This pull request adds the
packagesubcommand to OPAM, which exposes a command-line interface to lifecycle events already described by OPAM files. Specifically, this pull requests includes three subcommands:opam package buildruns thebuildscript of the OPAM file in the current project;opam package build-testruns thebuild-testscript of the OPAM file in the current project; andopam package build-docruns thebuild-docscript of the OPAM file in the current project.These commands will search an OPAM file in the typical locations, relative the current directory, e.g.,
opam,opam/opam, etc. In addition, the commands will also search up the directory tree for anopamfile and if found, use that to determine which commands to run.The
opam packagesubcommands can be used in any context, but were developed alongside directory sandbox support included in #2550. In conjuction with #2250, users can develop OPAM packages in local sandbox, using the switch associated with that sandbox while leaving the globally-configured switch unchanged, and out of the picture.This pull request targets the
nextbranch of OPAM development.As mentioned to @AltGr via email, this pull request intentionally does not include command-line documentation.