Pass fd to functions in OpamFilename.with_flock* #3248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dra27
added a commit
to dra27/opam
that referenced
this pull request
Mar 17, 2018
|
Ok to merge as soon as it passes (i.e. the #3242 dependency) |
AltGr
approved these changes
Mar 28, 2018
|
Rebased - expect AppVeyor to pass and Travis to fail the jobs < 4.06.1 |
dra27
added a commit
to dra27/opam
that referenced
this pull request
Apr 4, 2018
File locking behaves differently under Windows - if a file is to be written or read using a lock, then the same fd needs to be used. Alter the OpamFilename.with_flock functions to pass the fd of the lock file instead of unit. Signed-off-by: David Allsopp <david.allsopp@metastack.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File locking behaves differently under Windows - if a file is to be written or read using a lock, then the same fd needs to be used. Alter the OpamFilename.with_flock functions to pass the fd of the lock file
instead of unit.