Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opam show: string fields printed with quotes, as lists #3368

Merged
merged 1 commit into from
May 25, 2018
Merged

opam show: string fields printed with quotes, as lists #3368

merged 1 commit into from
May 25, 2018

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented May 23, 2018

this PR closes #3365

@avsm
Copy link
Member

avsm commented May 23, 2018

Does this escape contents inside the strings? That %s might be better off as %S instead

@rjbou
Copy link
Collaborator Author

rjbou commented May 23, 2018

As tags: (and most of fields) are not triple quote strings, they are already escaped in the opam file, which is kept by the format.
I updated the PR to match list printing, i.e. use OpamPrinter.value in case of single string field printing.

@avsm
Copy link
Member

avsm commented May 24, 2018

That makes sense, thanks :)

@AltGr AltGr merged commit 4f27534 into ocaml:master May 25, 2018
dra27 added a commit to dra27/opam that referenced this pull request Jul 21, 2018
@dra27
Adapt src_ext/update-sources.sh for ocaml#3368
3ae9949 
Output from `opam show` now includes quotes.
dra27 added a commit to dra27/opam that referenced this pull request Jul 23, 2018
@dra27
Adapt src_ext/update-sources.sh for ocaml#3368
94e9abd 
Output from `opam show` now includes quotes.
dra27 added a commit to dra27/opam that referenced this pull request Oct 14, 2018
@dra27
Adapt src_ext/update-sources.sh for ocaml#3368
32ac4c2 
Output from `opam show` now includes quotes.
rjbou pushed a commit to rjbou/opam that referenced this pull request Oct 16, 2018
@dra27 @rjbou
Adapt src_ext/update-sources.sh for ocaml#3368
359b1d9 
Output from `opam show` now includes quotes.
rjbou pushed a commit to rjbou/opam that referenced this pull request Oct 16, 2018
@dra27 @rjbou
Adapt src_ext/update-sources.sh for ocaml#3368
d0e0da3 
Output from `opam show` now includes quotes.
rjbou pushed a commit to rjbou/opam that referenced this pull request Oct 17, 2018
@dra27 @rjbou
Adapt src_ext/update-sources.sh for ocaml#3368
10b44d0 
Output from `opam show` now includes quotes.
@rjbou rjbou added this to the 2.0.1 milestone Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.

opam info for tags is hard to parse
3 participants
@rjbou @avsm @AltGr