Download error message #3397
Merged
Download error message #3397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AltGr
approved these changes
Jun 8, 2018
| @@ -20,7 +20,7 @@ open OpamStateTypes | |||
| This doesn't update dev packages that already have a locally cached | |||
| source. *) | |||
| val download_package: | |||
There was a problem hiding this comment.
Can the returned type be documented ?
| @@ -49,7 +49,7 @@ type std_path = | |||
| (** Download result *) | |||
| type 'a download = | |||
| | Up_to_date of 'a | |||
| | Not_available of string | |||
| | Not_available of string option * string | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #3393.
It adds two levels of download error message: a short one to be displayed on normal mode and a more complete one on verbose mode (when it is needed, when the message itself is short, it is the same on both modes). For the moment, no specific error download message is displayed to user, it is only filled on json file output when option is set.